Skip to content

Commit

Permalink
Remove some unnecessary window flush commands
Browse files Browse the repository at this point in the history
- I don't see why we would need these, especially now that
  the movie view is CoreAnimateion-based. I also don't see
  any detrimental effects from removing these commands.
  If strange visual bugs start showing up with fullscreen
  transitions then we'll know where to check first.
  • Loading branch information
samiamwork committed Feb 21, 2013
1 parent f74b186 commit 2d406b0
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions FullScreener_Transition.m
Expand Up @@ -73,7 +73,6 @@ - (void)hideMainMenuAndDock

- (void)attachMovieViewToFullWindow
{
[_mainWindow disableScreenUpdatesUntilFlush];
[_movieView removeFromSuperviewWithoutNeedingDisplay];
[_fullWindow setMovieView:_movieView];

Expand All @@ -88,9 +87,6 @@ - (void)attachMovieViewToFullWindow

- (void)detachMovieViewFromFullWindow
{
[_mainWindow disableScreenUpdatesUntilFlush];
[_mainWindow disableFlushWindow];

// move _movieView to _mainWindow from _fullWindow
[_movieView removeFromSuperviewWithoutNeedingDisplay];
[[_mainWindow contentView] addSubview:_movieView];
Expand All @@ -100,8 +96,6 @@ - (void)detachMovieViewFromFullWindow
[_mainWindow makeFirstResponder:_movieView];
[_mainWindow makeKeyAndOrderFront:nil];
[_mainWindow setHasShadow:TRUE];
[_mainWindow enableFlushWindow];
[_mainWindow flushWindowIfNeeded];
}

- (void)beginFullScreenFromDesktopBackground
Expand Down Expand Up @@ -163,8 +157,6 @@ - (void)beginFadeTransition:(float)fadeDuration
[self attachMovieViewToFullWindow];
[_fullWindow setFrame:[[_fullWindow screen] frame] display:TRUE];
[_fullWindow addChildWindow:_mainWindow ordered:NSWindowBelow];
[_fullWindow flushWindow];
[_mainWindow flushWindow];

[fader fadeIn:fadeDuration];
[[_movieView movie] setRate:rate];
Expand Down

0 comments on commit 2d406b0

Please sign in to comment.