Add 'Show Version' option to widget #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my logic on this proposed change:
In writing EDD compatibility with my theme, I am adding styling for this plugin, plus the software licensing plugin, both of which offer version information. However, there is no reliable way to hide that information on the widget output. There is no CSS solution as the version output is inside a li tag with no class or id, with the actual version number outside of the span. There is just no way to hide it. Using nth-child is also not very reliable. I see two ways to overcome that: Add the option, or add a class to that li tag. I opted for the former. It's nice to have that version info for some theme proprietary code, without having the actual widget output, and no css way to hide it.