Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert db calls to PDO, allow support for multiple back-end engines #164

Closed
samilliken opened this issue Mar 28, 2013 · 3 comments
Closed

Convert db calls to PDO, allow support for multiple back-end engines #164

samilliken opened this issue Mar 28, 2013 · 3 comments
Assignees
@samilliken
Labels
enhancement
Milestone
3.0-Release

Comments

@samilliken
Copy link
Member

With the combination of the existing mysql() calls being deprecated in the near future, and the political fallout of Oracle regarding MySQL, convert all calls to the PDO abstraction library. This will allow for various DB back-ends, as long as the SQL statements remain non version specific.
@ghost ghost assigned samilliken Mar 28, 2013
samilliken added a commit that referenced this issue Apr 10, 2013
@samilliken
Added a second db connection statement in the db.inc.php-dist file so…
fbf57a5 
… that we'll start using PDO rather than mysql_* calls. This will need to be manually updated for all users as we convert - will need to test for the connection in the next install.php and display a message to the user if we can't connect.

#164
samilliken added a commit that referenced this issue Apr 11, 2013
@samilliken
Converted config.inc.php functions to utilize the PDO database calls.…
389e3ae 
… I have not removed the parameter passed to the methods as that will happen as we replace all calls to the Config class.

#164
samilliken added a commit that referenced this issue Apr 11, 2013
@samilliken
Converted a couple of the methods in the Cabinet class to PDO databas…
a13ffa4 
…e calls and tested for functionality.

#164
samilliken added a commit that referenced this issue May 8, 2013
@samilliken
Added the field for User Right of AdminOwnDevices.
e046b3d 
Updated all of the User class methods to use PDO Library per #164

Updated the dc_stats, cabnavigator, and devices pages to base viewership on what departments a user is a member of, rather than the global ReadAccess right.

Use cabnavigator.php as the reference for how to handle the new right scheme.

#185
samilliken added a commit that referenced this issue May 15, 2013
@samilliken
Updating user rights and converting db calls to PDO.
e26772a 
Have completely converted the Cabinet class to PDO, set all of the $db parameters to be optional.  Updated files (contact and search) that used some methods with multiple parameters so that the $db is not passed at all.

#164
#185
samilliken added a commit that referenced this issue May 15, 2013
@samilliken
Completed conversion of Cabinet, CabinetAudit, and CabinetTemps class…
b5a2eb1 
…es to PDO library. Had to modify cabinets.php to make it work correctly.

#164

#185
@wilpig
Copy link
Collaborator

wilpig commented May 18, 2013

mysqlerror

We need a better way of displaying these as this completely breaks things and in turn also was completely useless in figuring out what happened.

https://github.com/samilliken/openDCIM/blob/37f078739fb8d8df2e1507bd4315987d9ded8635/assets.inc.php#L887

[Fri May 17 20:31:31 2013] [error] [client 129.59.141.208] PHP Warning: PDO::exec(): SQLSTATE[HY000]: General error: trying to execute an empty query in openDCIM/assets.inc.php on line 887, referer: devices.php?action=new&cabinet=2

[Fri May 17 20:35:50 2013] [error] [client 129.59.141.208] PHP Warning: sprintf(): Too few arguments in openDCIM/assets.inc.php on line 885, referer: devices.php?action=new&cabinet=2

And there is a perfect argument on why sprintf is bad for these statements.

@samilliken
Copy link
Member Author

There's a PDO parameter we can set that will put the errors in the error log.

wilpig added a commit that referenced this issue May 18, 2013
@wilpig
Correction to sql for create and update device errors. #164
b533a39
samilliken added a commit that referenced this issue May 18, 2013
@samilliken
Added info to error log if db error on the Device::CreateDevice metho…
f723aad 
…d. Need to propagate to the rest of the calls for consistency.

#164
samilliken added a commit that referenced this issue May 18, 2013
@samilliken
Merge branch 'master' of https://github.com/samilliken/openDCIM
49b61f7 
Conflicts:
	assets.inc.php

Fixed the error checking on the Device::CreateDevice method to send info to the error log.  Need to do to the rest of PDO calls for consistency.

#164
wilpig added a commit that referenced this issue May 18, 2013
@wilpig
Update SQL methods. Moved IP address field out of esx options to prim…
ac7fb36 
…ary device options. #164 close #189
wilpig added a commit that referenced this issue May 18, 2013
@wilpig
DB calls updated to PDO methods for all rackrequest functions. Correc…
9edd054 
…ted malfunctioning date and equipment type parameters in same functions. Updated a few translation strings to sprintf with static variables per best practices. Updated all translation files. #164
samilliken added a commit that referenced this issue May 18, 2013
@samilliken
Expanded the fac_Cabinet table to also have a HumiditySensorOID. Rena…
8a703e8 
…med the SensorOID to TempSensorOID.

Update the Cabinet class to reflect.

Also converted all of Cabinet class to PDO with error display in the error_log.

#155 for temperature/humidity portion

#164 for PDO error logging
samilliken added a commit that referenced this issue May 19, 2013
@samilliken
Converted class Device to PDO calls with error logging. Some function…
d7e8104 
…s that call other classes still must include the $db parameter until we're finished.

#164
wilpig added a commit that referenced this issue Jun 6, 2013
@wilpig
Added internationalization bits to the color codes and media types. T…
f6d6663 
…hat appears to be complete. close #190. Converted over the db calls in the configuration file to the PDO methods #164
wilpig added a commit that referenced this issue Jun 6, 2013
@wilpig
Massive search and replace for a few of the functions that have alrea…
9450d9f 
…dy been converted to PDO #164
wilpig added a commit that referenced this issue Jun 6, 2013
@wilpig
More PDO conversion and cleanup of spurious errors from PDO logging. …
1ecc139 
…A few functions are producing no data on return and it was interpreting that as an error even though it was a valid response. We need to be careful on straight select statements not to log an error if there is nothing returned. #164
wilpig added a commit that referenced this issue Jun 6, 2013
@wilpig
More PDO conversion. #164 Correction of errors on dc_dashboard from w…
ce6d32a 
…here methods have been changed and it was never updated. Need to revisit and see if this page is even needed, it was added @e13e35e
wilpig added a commit that referenced this issue Jun 6, 2013
@wilpig
Started to make the delete button for a CDU and got distracted conver…
ea81ab2 
…ting all the db calls to PDO. #194 #164
wilpig added a commit that referenced this issue Jun 7, 2013
@wilpig
More work on PDO conversion #164
5dc376b
wilpig added a commit that referenced this issue Jun 12, 2013
@wilpig
Converting PDU methods over to PDO. #164 Corrected a typo on a table …
e9d3a22 
…name for #137 fac_cabrow vs. fac_CabRow
wilpig added a commit that referenced this issue Jun 12, 2013
@wilpig
All CDU/PDU methods converted over to PDO as well as all references t…
7a78125 
…o these methods updated. #164
wilpig added a commit that referenced this issue Jun 19, 2013
@wilpig
More PDO conversion #164
918fae2
wilpig added a commit that referenced this issue Jun 25, 2013
@wilpig
Since nobody has spoken up on issues of the port conversions I am sta…
04f3be8 
…rting the method conversion. All ports methods are good to go except getPortList. No other files have been touched yet so attempting to alter switch connections will fail, right now. #191 #164
wilpig added a commit that referenced this issue Jul 5, 2013
@wilpig
Added the remove ports to the deletedevice method and more PDO conver…
a096579 
…sions. #191 #164
wilpig added a commit that referenced this issue Jul 5, 2013
@wilpig
The device class is 100% converted over to PDO. #164
5dda442
wilpig added a commit that referenced this issue Jul 9, 2013
@wilpig
ESX Class fully converted over to PDO. #164
2222a83
wilpig added a commit that referenced this issue Jul 10, 2013
@wilpig
assets.inc.php has been fully converted over to PDO. #164
9bf552b
wilpig added a commit that referenced this issue Jul 10, 2013
@wilpig
Started conversion of customers classes #164
35fa39f
wilpig added a commit that referenced this issue Jul 11, 2013
@wilpig
customers.inc.php conversion complete and all references have been up…
f2d286d 
…dated. Went ahead and ran a new gettext translation update as well. #164
wilpig added a commit that referenced this issue Jul 15, 2013
@wilpig
power.inc.php coverted over to PDO. Still need to hunt down all the p…
c70efd2 
…laces the methods are used and remove the db variable from them though. Out of time for this morning. #164
wilpig added a commit that referenced this issue Jul 18, 2013
@wilpig
Time to head home. More PDO conversion #164. Corrected the error brim…
98893e1 
…stone was seeing with the updating a department.
wilpig added a commit that referenced this issue Jul 23, 2013
@wilpig
More PDO conversion all inclusions are complete. Seeking out and conv…
fb3465d 
…erting all remaining instances of mysql_query #164
wilpig added a commit that referenced this issue Jul 23, 2013
@wilpig
Down to just the installer and conflicts.php for legacy support #164
27c2e47
wilpig added a commit that referenced this issue Jul 23, 2013
@wilpig
I think all the mysql specific references have now been eliminated. T…
cef4f10 
…EST EVERYTHING! #164
@samilliken
Copy link
Member Author

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samilliken samilliken

Labels
enhancement
Projects
None yet
Milestone
3.0-Release
Development

No branches or pull requests
2 participants
@wilpig @samilliken