Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#6 - Initial markdown support for headers #8

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

batunpc
Copy link
Contributor

@batunpc batunpc commented Sep 21, 2022

I have added md file support along with the heading feature. During this process majority of my implementations were in src/File.py however I also have provided README.md modifications in my subsequent commit.
While implementing the heading feature I have considered the following cases:

  • There are 6 levels of headings in markdown each denoted with a # sign.
  • Each level of heading is converted into corresponding HTML heading tag.

Also an working example shown below
CleanShot 2022-09-21 at 02 24 55@2x

I tried to follow similar code pattern and named the function as process_md_file

As discussed in Issue#6 this feature consists support to markdown in the manner of headers. This can be tested with the test file in dataset/markdown.md file
@saminarp saminarp merged commit 113cc53 into saminarp:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants