Dynamic swap mvp #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwappableSlot: add GPU-to-GPU reset feature
…into dynamic_swap_mvp
…efault valueis in options
Also use unique_ptr to ensure this
Allow swappable models to change "max_length_factor" at runtime.
…_save Features/delayed valid and save
…nd_save Features/postpones valid and save
removed useless check because variable "from" is always defined
…stpones_valid_and_save Features/postpones valid and save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a clear and concise description of the changes.
This PR fixes a bug/adds a new feature/refactorizes the code/does something else.
It is related to issues: marian-nmt#998, marian-nmt#999, ...
List of changes:
Added dependencies: none
How to test
Describe how to test your changes, adding command line examples and sample input/output files if relevant.
Point to unit tests or regression tests covering the changes if they have been added.
Describe how you have tested your code, including OS and the cmake command.
Checklist