Feat/cache privatekey #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samirtahir91
force-pushed
the
feat/cache-privatekey
branch
2 times, most recently
from
ab9147f
to
31730a7
Compare
- Private keys are cached in /var/run/github-app-secrets/<namespace>/<githubapp name> - A githubapp's cached key is wiped on delete of a github app - Cache key is wiped if there is an error in the access token request from github api for a githubapp - Reduces calls to kubernetes api for token request and secrets and/or vault - Up manager seccompProfile for RuntimeDefault
samirtahir91
force-pushed
the
feat/cache-privatekey
branch
from
7dbd9e0
to
e784736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.