Update workflows to not fail if pytest rerun was successful (signalfx…

…#3593)
samiura · Sep 7, 2023 · eb86d92 · eb86d92
1 parent 9c10477
commit eb86d92
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/installer-script-test.yml b/.github/workflows/installer-script-test.yml
@@ -84,6 +84,7 @@ jobs:
 
       - name: Test installer script
         id: pytest
+        continue-on-error: true
         run: |
           distro="${{ matrix.DISTRO }}"
           if [[ "$distro" = "amazonlinux-2" ]]; then
@@ -95,7 +96,7 @@ jobs:
 
       # qemu, networking, running systemd in containers, etc., can be flaky
       - name: Re-run failed tests
-        if: ${{ failure() && steps.pytest.conclusion == 'failure' }}
+        if: ${{ steps.pytest.outcome == 'failure' }}
         run: |
           distro="${{ matrix.DISTRO }}"
           if [[ "$distro" = "amazonlinux-2" ]]; then

diff --git a/.github/workflows/linux-package-test.yml b/.github/workflows/linux-package-test.yml
@@ -225,6 +225,7 @@ jobs:
 
       - name: Test ${{ env.SYS_PACKAGE }} on ${{ matrix.DISTRO }} ${{ matrix.ARCH }}
         id: pytest
+        continue-on-error: true
         run: |
           distro="${{ matrix.DISTRO }}"
           if [[ "$distro" = "amazonlinux-2" ]]; then
@@ -237,7 +238,7 @@ jobs:
 
       # qemu, networking, running systemd in containers, etc., can be flaky
       - name: Re-run failed tests
-        if: ${{ failure() && steps.pytest.conclusion == 'failure' }}
+        if: ${{ steps.pytest.outcome == 'failure' }}
         run: |
           distro="${{ matrix.DISTRO }}"
           if [[ "$distro" = "amazonlinux-2" ]]; then

diff --git a/.github/workflows/puppet-test.yml b/.github/workflows/puppet-test.yml
@@ -104,6 +104,7 @@ jobs:
 
       - name: Test puppet deployment
         id: pytest
+        continue-on-error: true
         run: |
           distro="${{ matrix.DISTRO }}"
           if [[ "$distro" = "amazonlinux-2" ]]; then
@@ -117,7 +118,7 @@ jobs:
 
       # qemu, networking, running systemd in containers, etc., can be flaky
       - name: Re-run failed tests
-        if: ${{ failure() && steps.pytest.conclusion == 'failure' }}
+        if: ${{ steps.pytest.outcome == 'failure' }}
         run: |
           distro="${{ matrix.DISTRO }}"
           if [[ "$distro" = "amazonlinux-2" ]]; then
@@ -160,6 +161,7 @@ jobs:
 
       - name: Test puppet deployment
         id: pytest
+        continue-on-error: true
         run: |
           pytest -s --verbose -m windows `
             -k ${{ matrix.TEST_CASE }} `
@@ -168,7 +170,7 @@ jobs:
           PUPPET_RELEASE: "${{ matrix.PUPPET_RELEASE }}"
 
       - name: Re-run failed tests
-        if: ${{ failure() && steps.pytest.conclusion == 'failure' }}
+        if: ${{ steps.pytest.outcome == 'failure' }}
         run: |
           pytest -s --verbose -m windows `
             --last-failed `

diff --git a/.github/workflows/salt-test.yml b/.github/workflows/salt-test.yml
@@ -90,6 +90,7 @@ jobs:
 
       - name: Test salt deployment
         id: pytest
+        continue-on-error: true
         run: |
           distro="${{ matrix.DISTRO }}"
           if [[ "$distro" = "amazonlinux-2" ]]; then
@@ -101,7 +102,7 @@ jobs:
 
       # qemu, networking, running systemd in containers, etc., can be flaky
       - name: Re-run failed tests
-        if: ${{ failure() && steps.pytest.conclusion == 'failure' }}
+        if: ${{ steps.pytest.outcome == 'failure' }}
         run: |
           distro="${{ matrix.DISTRO }}"
           if [[ "$distro" = "amazonlinux-2" ]]; then