Merge pull request #317 from ron7684/bugfix/requests_params_signature

Apply requests_params and remove from data before generating signature
sammchardy · Jan 23, 2019 · 4ad8457 · 4ad8457
2 parents ae444b9 + 9ff962f
commit 4ad8457
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/binance/client.py b/binance/client.py
@@ -150,19 +150,20 @@ def _request(self, method, uri, signed, force_params=False, **kwargs):
         data = kwargs.get('data', None)
         if data and isinstance(data, dict):
             kwargs['data'] = data
-        if signed:
-            # generate signature
-            kwargs['data']['timestamp'] = int(time.time() * 1000)
-            kwargs['data']['signature'] = self._generate_signature(kwargs['data'])
 
-        # sort get and post params to match signature order
-        if data:
             # find any requests params passed and apply them
             if 'requests_params' in kwargs['data']:
                 # merge requests params into kwargs
                 kwargs.update(kwargs['data']['requests_params'])
                 del(kwargs['data']['requests_params'])
 
+        if signed:
+            # generate signature
+            kwargs['data']['timestamp'] = int(time.time() * 1000)
+            kwargs['data']['signature'] = self._generate_signature(kwargs['data'])
+
+        # sort get and post params to match signature order
+        if data:
             # sort post params
             kwargs['data'] = self._order_params(kwargs['data'])