Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the Binance API URLs in env #313

Closed
wants to merge 1 commit into from

Conversation

subos2008
Copy link

To allow for testing and development against mock / caching endpoints.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 41.368% when pulling 55616df on subos2008:master into 852b256 on sammchardy:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 41.368% when pulling 55616df on subos2008:master into 852b256 on sammchardy:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 41.368% when pulling 55616df on subos2008:master into 852b256 on sammchardy:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 41.368% when pulling 55616df on subos2008:master into 852b256 on sammchardy:master.

@sammchardy
Copy link
Owner

Hi @subos2008 if you check how I test, I use the requests_mock library to do this.

See examples here https://github.com/sammchardy/python-binance/blob/master/tests/test_api_request.py

@sammchardy sammchardy closed this Aug 8, 2018
@subos2008
Copy link
Author

@sammchardy thanks for taking the time to look at this.

It's not testing I want to use this for.

To reduce the number of requests for historical klines data against the Binance API I have produced a transparent cache that replicates the Binance API. I want to be able to point your library at this caching endpoint rather than the exchange.

Hope that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants