aggregate_trade_iter(): fixed empty resulting set problem #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youstanzr
approved these changes
Jan 6, 2019
anson-vandoren
approved these changes
Jan 6, 2019
There was a problem hiding this comment.
@sapph1re, thanks for finding this and submitting your solution. Just ran into the same issue and this saved me from writing some code.
@sammchardy, can you take a look and merge this? Thanks!
sammchardy
changed the base branch from
master
to
bugfix/aggregate_trade_iter_empty_set
|
Thanks @sapph1re |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341.
When starting from startStr, if the first hour doesn't contain any trades, it will now not crash, but move forward hour by hour until it at least one trade is found or present moment is reached.