Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Futures Prices Websocket #602

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

jiyoungsin
Copy link
Contributor

No description provided.

@kimchirichie
Copy link
Contributor

additive code & functional. looks good to me

@kimchirichie
Copy link
Contributor

will merge in once a few people can confirm its functionality

@kimchirichie kimchirichie added the Pending verification pending on at least 2 users testing, and verifying it works label Oct 22, 2020
@CyrilleBoullier
Copy link

Hello, do you know when you will merge this branch?

will futures prices be available also for the branch feature/asyncio?

Thanks,
Cyrille.

@kimchirichie
Copy link
Contributor

i think this one is pretty safe to merge. all additive code. @CyrilleBoullier would you be able to test this branch and confirm it works?

@CyrilleBoullier
Copy link

Yes, if you add it also in the branch feature/asyncio then I can test it as I'm using it 24h/24h with a set of 4 cryptos.

Regards,
Cyrille.

@kimchirichie
Copy link
Contributor

@CyrilleBoullier I may be confused, but feature/asyncio is unrelated to this branch. I will merge this one in since its only additive and will not effect any existing users.

@kimchirichie kimchirichie merged commit 4076537 into sammchardy:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending verification pending on at least 2 users testing, and verifying it works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants