Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Fix server network restart #46

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

lemantisee
Copy link
Contributor

@lemantisee lemantisee commented Jun 1, 2023

Fix restarting network module in NetImguiServer.
This is necessary for restarting NetImguiServer without restarting whole application.

Signed-off-by: Kostiantyn Chernenok <kos.chernenok@gmail.com>
Copy link
Owner

@sammyfreg sammyfreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you stop call Shutdown and then Restart?
The only thing I could see missing, is making sure that the shutdown completed before the we reach line 366,

@lemantisee
Copy link
Contributor Author

lemantisee commented Jun 1, 2023

I call NetImguiServer::App::Shutdown and than NetImguiServer::App::Startup.
In NetImguiServer::App::Shutdown gbShutdown is set to true which disables loop in NetworkConnectRequest_Send to establish new connections with clients. So after call NetImguiServer::App::Startup we can't see clients in network.

@sammyfreg sammyfreg merged commit a1aec15 into sammyfreg:dev Jun 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants