Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopping navbar on every reload/page change #188

Closed
Mojo90 opened this issue Nov 26, 2017 · 2 comments
Closed

Hopping navbar on every reload/page change #188

Mojo90 opened this issue Nov 26, 2017 · 2 comments

Comments

@Mojo90
Copy link

Mojo90 commented Nov 26, 2017

I recognized on my site that the navbar hopps up (I think 4px) on every reload or page change after a few milliseconds. Than I saw that it is the same on shopkit site (https://shopkit.samnabi.com), so it is not an error on my site. Maybe has to do sth. with the lines from 437 in shopkit.scss:

button[aria-expanded="false"] + * {
	opacity: 0;
	max-height: 0 !important; /* Overrides the inline max-height applied by JavaScript */
}
.animate button[aria-expanded] + * {
	transition: max-height 0.3s, opacity 0.5s;
}

But I am not sure.

@samnabi
Copy link
Owner

samnabi commented Nov 27, 2017

This is a weird positioning issue involving a combination of absolute positioning and borders.

This is Fixed by adding border: 2px solid $accent; to the .animate .login form selector instead of .login form.

(Fix to the master branch is coming in a few days.)

@Mojo90
Copy link
Author

Mojo90 commented Nov 27, 2017

Yep perfect that does the trick, thanks!

@Mojo90 Mojo90 closed this as completed Nov 27, 2017
samnabi added a commit that referenced this issue Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants