Added Int64Slice,StrSlice,Float64Slice and BoolSlice #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derkan
changed the title
samonzeweb
reviewed
Nov 29, 2018
types/boolslice_test.go
Outdated
| vx, err := nullBoolSlice.Value() | ||
| So(err, ShouldEqual, nil) | ||
| So(string(vx.([]byte)), ShouldEqual, `[true,false,true]`) | ||
|
|
types/float64slice_test.go
Outdated
| vx, err := nullFloat64Slice.Value() | ||
| So(err, ShouldEqual, nil) | ||
| So(string(vx.([]byte)), ShouldEqual, `[1.1,2.2,3.3]`) | ||
|
|
types/int64slice_test.go
Outdated
| vx, err := nullInt64Slice.Value() | ||
| So(err, ShouldEqual, nil) | ||
| So(string(vx.([]byte)), ShouldEqual, `[1,2,3]`) | ||
|
|
| // | ||
| // | ||
| // package main | ||
|
|
There was a problem hiding this comment.
Comment ALL the example code (even blank lines)
types/strslice_test.go
Outdated
| vx, err := nullStrSlice.Value() | ||
| So(err, ShouldEqual, nil) | ||
| So(string(vx.([]byte)), ShouldEqual, `["a","b","c"]`) | ||
|
|
types/boolslice_test.go
Outdated
| Convey("Given BoolSlice", t, func() { | ||
| Convey("valid value", func() { | ||
| v := []bool{true, false, true} | ||
| nullBoolSlice := BoolSlice(v) |
There was a problem hiding this comment.
Why using nullBoolSlice in every tests, even when there is no involved null/nil values ?
(same for all tests of all new types).
There was a problem hiding this comment.
At first I also added Null* types to these new types, but that was redundant as slices can be nil. Those null... named variables are spoils from that try. All "null" can be renamed to "v" so it will become for example vBoolSlice for BoolSlice. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Int64Slice,Float64Slice,BoolSliceandStrSlicetotypespackage.StrSliceconverts[]string{"a","b","c"}to JSON bytes["a","b","c"]which can be saved toBLOB, VARCHAR, TEXT. And when it reads["a","b","c"]from DB, it converts to[]string{"a","b","c"}Int64Sliceconverts[]int64{1,2,3}to JSON bytes[1,2,3]which can be saved toBLOB, VARCHAR, TEXT. And when it reads[1,2,3]from DB, it converts to[]int64{1,2,3}Float64Sliceconverts[]float64{1.1,2.2,3.3}to JSON bytes[1.1,2.2,3.3]which can be saved toBLOB, VARCHAR, TEXT. And when it reads[1.1,2.2,3.3]from DB, it converts to[]float64{1.1,2.2,3.3}Bool64Sliceconverts[]bool{true,false,true}to JSON bytes[true,false,true]which can be saved toBLOB, VARCHAR, TEXT. And when it reads[true,false,true]from DB, it converts to[]bool{true,false,true}Each can be nil also.
Closes #28