Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed driver dependencies #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

derkan
Copy link
Contributor

@derkan derkan commented Jun 30, 2021

Hi Samuel, I hope you are doing well. I removed db driver dependencies in this PR.

PR provides using pgx/stdlib driver instead of pg(or modernc.org/sqlite instead of mattn/go-sqlite3...). Also this makes exe size smaller when user uses alternate drivers.

Only drawback: user should import his/her driver before using it(not auto imported when imported relevant adapter. And I think mostly users do this beforehand.

@samonzeweb
Copy link
Owner

Hi Derkan,

It's a breaking change. I can't do this without publishing a "v2".

I've another problem : no time to maintain this seriously. I will test on newer Go versions and update the test matrix and README, but nothing more, at least in short time. It took me almost 3 weeks to reply, it's not very serious as a maintainer, I'm sorry.

The project is stable, it's usable as-is. Next major evolution could involve generics. Also I think code generation is also better then reflection. If something will evolve, it will rather be a revolution.

If you fork durably the project I could mention it in the README. I will not be very available next weeks, but I'll do it, at worse in September.

Samuel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants