Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix javascript enabled #14

Merged
merged 2 commits into from Jan 21, 2019
Merged

fix javascript enabled #14

merged 2 commits into from Jan 21, 2019

Conversation

Rockson
Copy link

@Rockson Rockson commented Sep 20, 2018

Closes #13
Also should be a flag, but probably there is no downside on enabling it by default

@notsafe
Copy link

notsafe commented Oct 9, 2018

Since the default behavior is disabled, I think you should at least do a check
something like

const lessOpts = {
	paths: ['.', path.dirname(options.src)].concat(options.paths),
	sourceMap: {},
	javascriptEnabled: !!options.js
};

@Abazhenov
Copy link

Any chance of this getting merged soon?

@Ragzzy-R
Copy link

Has this been merged to main branch? I get the issue #13 while using ^0.3.1 as I have not ejected my create-react-app, there is no way I can enable Javascript myself.

@Rockson
Copy link
Author

Rockson commented Dec 22, 2018

I think that until this gets merged u can fork my repo and install the package using git url

@Ragzzy-R
Copy link

Yeah I ended up just changing the code to whatever you did in PR and it works now. thanks man really u are a life saver.

@sampi sampi merged commit 7b88f36 into sampi:master Jan 21, 2019
sampi pushed a commit that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants