Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Link Headers #1003

Merged
merged 1 commit into from
May 24, 2023
Merged

Add Link Headers #1003

merged 1 commit into from
May 24, 2023

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented May 23, 2023

Add link headers according to RFC 8288 to responses with searchset bundles. This enabled clients to obtain links without the need to parse the bundle itself. The idea is to lower the time a client needs to request the next page.

@alexanderkiel alexanderkiel self-assigned this May 23, 2023
@alexanderkiel alexanderkiel modified the milestones: v0.20.7, v0.21.0 May 23, 2023
@alexanderkiel alexanderkiel added enhancement New feature or request performance Performance improvement module:rest-api labels May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #1003 (80c0e46) into develop (0d6f225) will increase coverage by 0.01%.
The diff coverage is 97.36%.

❗ Current head 80c0e46 differs from pull request most recent head 935242c. Consider uploading reports for the commit 935242c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1003      +/-   ##
===========================================
+ Coverage    94.20%   94.22%   +0.01%     
===========================================
  Files          238      239       +1     
  Lines        15233    15258      +25     
  Branches       374      373       -1     
===========================================
+ Hits         14351    14377      +26     
  Misses         508      508              
+ Partials       374      373       -1     
Impacted Files Coverage Δ
modules/rest-api/src/blaze/rest_api/routes.clj 97.52% <96.15%> (+0.17%) ⬆️
...api/src/blaze/rest_api/middleware/link_headers.clj 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Add link headers according to RFC 8288 to responses with searchset
bundles. This enabled clients to obtain links without the need to parse
the bundle itself. The idea is to lower the time a client needs to
request the next page.
@alexanderkiel alexanderkiel merged commit d939902 into develop May 24, 2023
127 checks passed
@alexanderkiel alexanderkiel deleted the link-headers branch May 24, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module:rest-api performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant