Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RocksDB Block Cache Usage Metrics #1008

Merged
merged 1 commit into from
May 28, 2023

Conversation

alexanderkiel
Copy link
Member

The metrics are called blaze_rocksdb_block_cache_usage_bytes and blaze_rocksdb_block_cache_pinned_usage_bytes.

@alexanderkiel alexanderkiel self-assigned this May 28, 2023
@alexanderkiel alexanderkiel added enhancement New feature or request operation Operational issues like monitoring and maintenance. labels May 28, 2023
@alexanderkiel alexanderkiel added this to the v0.21.0 milestone May 28, 2023
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #1008 (5b4f6ea) into develop (0c53e32) will decrease coverage by 0.01%.
The diff coverage is 93.33%.

❗ Current head 5b4f6ea differs from pull request most recent head 858180f. Consider uploading reports for the commit 858180f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1008      +/-   ##
===========================================
- Coverage    94.23%   94.22%   -0.01%     
===========================================
  Files          239      239              
  Lines        15258    15271      +13     
  Branches       372      373       +1     
===========================================
+ Hits         14378    14389      +11     
- Misses         508      509       +1     
- Partials       372      373       +1     
Impacted Files Coverage Δ
modules/rocksdb/src/blaze/db/kv/rocksdb.clj 99.08% <66.66%> (-0.92%) ⬇️
modules/metrics/src/blaze/metrics/core.clj 100.00% <100.00%> (ø)
...odules/rocksdb/src/blaze/db/kv/rocksdb/metrics.clj 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

The metrics are called blaze_rocksdb_block_cache_usage_bytes and
blaze_rocksdb_block_cache_pinned_usage_bytes.
@alexanderkiel alexanderkiel merged commit 1054216 into develop May 28, 2023
125 checks passed
@alexanderkiel alexanderkiel deleted the rocksdb-block-cache-metrics branch May 28, 2023 19:46
@alexanderkiel alexanderkiel added module:rocksdb and removed enhancement New feature or request labels May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:rocksdb operation Operational issues like monitoring and maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant