Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Comparison of Length Result not Possible in CQL #1035

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

alexanderkiel
Copy link
Member

The CQL Length function returned an integer instead of a long. However the comparison operators work only with longs. I fixed that by ensuring that Length returns a long.

The CQL Length function returned an integer instead of a long. However
the comparison operators work only with longs. I fixed that by ensuring
that Length returns a long.
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1035 (9cfdd3f) into develop (6f72982) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1035      +/-   ##
===========================================
+ Coverage    94.26%   94.33%   +0.07%     
===========================================
  Files          239      239              
  Lines        15291    15293       +2     
  Branches       370      368       -2     
===========================================
+ Hits         14414    14427      +13     
+ Misses         507      498       -9     
+ Partials       370      368       -2     
Impacted Files Coverage Δ
...es/cql/src/blaze/elm/compiler/string_operators.clj 93.40% <100.00%> (ø)
...dules/rest-api/src/blaze/rest_api/capabilities.clj 97.32% <100.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

@alexanderkiel alexanderkiel merged commit 9526a96 into develop Jun 16, 2023
128 checks passed
@alexanderkiel alexanderkiel deleted the fix-cql-length-comparison branch June 16, 2023 09:04
@alexanderkiel alexanderkiel self-assigned this Jun 16, 2023
@alexanderkiel alexanderkiel added bug Something isn't working module:cql labels Jun 16, 2023
@alexanderkiel alexanderkiel modified the milestones: v0.21.1, v0.22.0 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:cql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant