Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure History Changes only if Resource Changes #1041

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented Jun 25, 2023

This change introduces a new trasnaction command called "keep" that just means: "Keep the resource of it is not changed in between." Unlike "put", "keep" will not introduce a new history entry. The command "keep" is always conditional because the detection of no changes will be done outside of the transaction.

Closes: #777

@alexanderkiel alexanderkiel self-assigned this Jun 25, 2023
@alexanderkiel alexanderkiel added the enhancement New feature or request label Jun 25, 2023
@alexanderkiel alexanderkiel added this to the v0.22.0 milestone Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #1041 (6994522) into develop (3982d14) will increase coverage by 0.07%.
The diff coverage is 99.67%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1041      +/-   ##
===========================================
+ Coverage    94.40%   94.48%   +0.07%     
===========================================
  Files          243      243              
  Lines        15466    15639     +173     
  Branches       369      368       -1     
===========================================
+ Hits         14601    14776     +175     
+ Misses         496      495       -1     
+ Partials       369      368       -1     
Impacted Files Coverage Δ
modules/db/src/blaze/db/impl/db.clj 91.54% <0.00%> (ø)
modules/anomaly/src/blaze/anomaly.clj 100.00% <100.00%> (ø)
modules/anomaly/src/blaze/anomaly_spec.clj 100.00% <100.00%> (ø)
modules/async/src/blaze/async/comp.clj 100.00% <100.00%> (ø)
modules/async/src/blaze/async/comp_spec.clj 100.00% <100.00%> (ø)
...assandra/src/blaze/db/resource_store/cassandra.clj 98.00% <100.00%> (ø)
modules/db/src/blaze/db/impl/index/cbor.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/impl/index/tx_error.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/node.clj 97.99% <100.00%> (+0.06%) ⬆️
modules/db/src/blaze/db/node/transaction.clj 100.00% <100.00%> (ø)
... and 18 more

... and 2 files with indirect coverage changes

@alexanderkiel alexanderkiel force-pushed the noop-update branch 3 times, most recently from 5e1b05b to 9959f2a Compare June 29, 2023 14:06
@alexanderkiel alexanderkiel changed the title [WIP] Ensure History Changes only if Resource Changes Ensure History Changes only if Resource Changes Jun 29, 2023
@alexanderkiel alexanderkiel force-pushed the noop-update branch 5 times, most recently from ceac9d2 to b066bf9 Compare June 29, 2023 20:25
This change introduces a new transaction command called "keep" that just
means: "Keep the resource of it is not changed in between." Unlike
"put", "keep" will not introduce a new history entry. The command "keep"
is always conditional because the detection of no changes will be done
outside of the transaction.

Closes: #777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant