Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Allocation Heavy Functions #1198

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

alexanderkiel
Copy link
Member

The cuerdas functions kebab and trim create regular expressions on every call. This results in high memory allocation rate. This performance fix reduces the memory allocation amount for kebab ten fold.

The cuerdas functions kebab and trim create regular expressions on every
call. This results in high memory allocation rate. This performance fix
reduces the memory allocation amount for kebab ten fold.
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1198 (3d34286) into develop (7d95462) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1198   +/-   ##
========================================
  Coverage    94.77%   94.77%           
========================================
  Files          242      242           
  Lines        15636    15643    +7     
  Branches       365      365           
========================================
+ Hits         14819    14826    +7     
  Misses         452      452           
  Partials       365      365           
Files Coverage Δ
modules/cql/src/blaze/elm/compiler/core.clj 92.45% <100.00%> (ø)
modules/cql/src/blaze/elm/deps_infer.clj 80.58% <100.00%> (ø)
modules/cql/src/blaze/elm/equiv_relationships.clj 88.67% <100.00%> (ø)
modules/cql/src/blaze/elm/normalizer.clj 88.32% <100.00%> (ø)
modules/cql/src/blaze/elm/quantity.clj 99.09% <100.00%> (+<0.01%) ⬆️
modules/cql/src/blaze/elm/util.clj 90.90% <100.00%> (+3.40%) ⬆️
modules/fhir-path/src/blaze/fhir_path.clj 89.10% <100.00%> (+0.03%) ⬆️
modules/interaction/src/blaze/interaction/util.clj 100.00% <100.00%> (ø)

@alexanderkiel alexanderkiel merged commit 5973907 into develop Oct 11, 2023
135 checks passed
@alexanderkiel alexanderkiel deleted the feature/mem-alloc-perf branch October 11, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant