Improve Hashing Performance #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderkiel
force-pushed
the
improve-hashing-perf
branch
from
095a9d0
to
7b39f99
Compare
Hashing a typical Observations shows a 10% runtime speedup. On top of that, fewer garbage is produced because instead of a new map, only a new list of keys is produced.
alexanderkiel
force-pushed
the
improve-hashing-perf
branch
from
7b39f99
to
f010029
Compare
Codecov Report
@@ Coverage Diff @@
## develop #297 +/- ##
===========================================
+ Coverage 87.63% 87.71% +0.08%
===========================================
Files 193 193
Lines 12040 12041 +1
Branches 463 458 -5
===========================================
+ Hits 10551 10562 +11
+ Misses 1026 1021 -5
+ Partials 463 458 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashing a typical Observations shows a 10% runtime speedup. On top of
that, fewer garbage is produced because instead of a new map, only a new
list of keys is produced.