Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CQL Error Message on Subtract #755

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented Jul 1, 2022

Also do not log expected errors on single expression evaluation because that results in a very high amount of logging.

@alexanderkiel alexanderkiel self-assigned this Jul 1, 2022
@alexanderkiel alexanderkiel added this to the v0.17.9 milestone Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #755 (2b76d13) into develop (ebc0762) will increase coverage by 0.04%.
The diff coverage is 96.34%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #755      +/-   ##
===========================================
+ Coverage    93.58%   93.62%   +0.04%     
===========================================
  Files          233      233              
  Lines        14300    14362      +62     
  Branches       390      391       +1     
===========================================
+ Hits         13382    13447      +65     
+ Misses         528      524       -4     
- Partials       390      391       +1     
Impacted Files Coverage Δ
...fhir-structure/src/blaze/fhir/spec/type/system.clj 91.66% <92.30%> (+0.03%) ⬆️
modules/cql/src/blaze/elm/date_time.clj 93.75% <94.28%> (+0.61%) ⬆️
modules/anomaly/src/blaze/anomaly.clj 100.00% <100.00%> (ø)
...ules/cql/src/blaze/elm/compiler/type_operators.clj 83.19% <100.00%> (+0.73%) ⬆️
modules/cql/src/blaze/elm/deps_infer.clj 77.50% <100.00%> (+0.07%) ⬆️
modules/cql/src/blaze/elm/nil.clj 100.00% <100.00%> (ø)
modules/cql/src/blaze/elm/protocols.clj 100.00% <100.00%> (ø)
modules/cql/src/blaze/elm/string.clj 100.00% <100.00%> (ø)
.../src/blaze/fhir/operation/evaluate_measure/cql.clj 93.45% <100.00%> (+0.20%) ⬆️

Also do not log expected errors.
@alexanderkiel alexanderkiel merged commit 3d2bd2e into develop Jul 1, 2022
@alexanderkiel alexanderkiel deleted the cql-error-msg branch July 1, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant