Improve Performance Evaluating Measures without Stratifier #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderkiel
added
enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #962 +/- ##
===========================================
- Coverage 94.06% 94.04% -0.02%
===========================================
Files 240 238 -2
Lines 15034 15067 +33
Branches 379 381 +2
===========================================
+ Hits 14141 14170 +29
- Misses 514 516 +2
- Partials 379 381 +2
|
alexanderkiel
force-pushed
the
cql-population
branch
from
d64b7bb
to
a4f9aba
Compare
Evaluating a Measure with reportType of population and no stratifier doesn't need collect the handles. This change determines that situation and just calculates the population count instead of collecting all handles. This changes enables Blaze to determine the count of large populations were previously lots of memory was used for no reason. The speedup documented in docs/performance/cql.md is not from this change. I improved the cache sizes and GC in order to achieve the performance gains. I added the observation-category-laboratory query to show that we can now count 170 M observations without using heap memory.
alexanderkiel
force-pushed
the
cql-population
branch
from
a4f9aba
to
30144ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluating a Measure with reportType of population and no stratifier doesn't need collect the handles. This change determines that situation and just calculates the population count instead of collecting all handles.
This changes enables Blaze to determine the count of large populations were previously lots of memory was used for no reason.