Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Case of Missing Resource Contents #974

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

alexanderkiel
Copy link
Member

Before non-found resource contents would not handled correctly. The nil content would just enhanced with some meta information and the so incomplete resource without type would case all sorts of other problems.

Now pull d/pull, d/pull-content and d/pull-many will return not-found anomalies what will be translated into faults in the REST layer.

@alexanderkiel alexanderkiel self-assigned this Apr 27, 2023
@alexanderkiel alexanderkiel force-pushed the handle-missing-resource-content branch from 0e6a0d8 to 2379e51 Compare April 28, 2023 12:37
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #974 (71eeabe) into develop (e438514) will increase coverage by 0.04%.
The diff coverage is 97.84%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #974      +/-   ##
===========================================
+ Coverage    94.05%   94.09%   +0.04%     
===========================================
  Files          238      238              
  Lines        15075    15152      +77     
  Branches       382      380       -2     
===========================================
+ Hits         14179    14258      +79     
  Misses         514      514              
+ Partials       382      380       -2     
Impacted Files Coverage Δ
modules/db/src/blaze/db/api.clj 83.03% <ø> (ø)
...dules/rest-util/src/blaze/fhir/response/create.clj 96.55% <ø> (ø)
...interaction/src/blaze/interaction/history/type.clj 93.47% <86.66%> (+0.62%) ⬆️
...raction/src/blaze/interaction/history/instance.clj 97.91% <93.75%> (+0.18%) ⬆️
modules/db/src/blaze/db/node.clj 97.92% <100.00%> (+0.10%) ⬆️
...odules/fhir-structure/src/blaze/fhir/spec/impl.clj 95.90% <100.00%> (+<0.01%) ⬆️
...dules/interaction/src/blaze/interaction/create.clj 98.24% <100.00%> (+0.37%) ⬆️
...teraction/src/blaze/interaction/history/system.clj 100.00% <100.00%> (ø)
modules/interaction/src/blaze/interaction/read.clj 100.00% <100.00%> (ø)
...ction/src/blaze/interaction/search_compartment.clj 93.61% <100.00%> (+0.13%) ⬆️
... and 6 more

... and 2 files with indirect coverage changes

Before non-found resource contents would not handled correctly. The nil
content would just enhanced with some meta information and the so
incomplete resource without type would case all sorts of other problems.

Now pull d/pull, d/pull-content and d/pull-many will return not-found
anomalies what will be translated into faults in the REST layer.
@alexanderkiel alexanderkiel force-pushed the handle-missing-resource-content branch from 2379e51 to 71eeabe Compare April 28, 2023 13:22
@alexanderkiel alexanderkiel merged commit e5b46ee into develop Apr 28, 2023
93 checks passed
@alexanderkiel alexanderkiel deleted the handle-missing-resource-content branch April 28, 2023 14:48
@alexanderkiel alexanderkiel added this to the v0.20.4 milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant