Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Date Equal Search and Add Missing Prefixes #975

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

alexanderkiel
Copy link
Member

The equal search worked like approximately (ap) search. Now it tests for fully contains instead of overlapping. The Prefixes sa (starts-after), eb (ends-before) and ap (approximately) were also added.

Closes: #666

@alexanderkiel alexanderkiel self-assigned this Apr 30, 2023
@alexanderkiel alexanderkiel added bug Something isn't working enhancement New feature or request module:db labels Apr 30, 2023
@alexanderkiel alexanderkiel force-pushed the fix-date-search branch 2 times, most recently from 4d2f306 to f2afb57 Compare April 30, 2023 16:57
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #975 (b32077a) into develop (71eeabe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
+ Coverage    94.09%   94.12%   +0.02%     
===========================================
  Files          238      238              
  Lines        15152    15233      +81     
  Branches       380      380              
===========================================
+ Hits         14258    14338      +80     
- Misses         514      515       +1     
  Partials       380      380              
Impacted Files Coverage Δ
modules/anomaly/src/blaze/anomaly.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/impl/codec/date.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/impl/search_param/date.clj 97.56% <100.00%> (+0.36%) ⬆️
...odules/db/src/blaze/db/impl/search_param/token.clj 95.16% <100.00%> (ø)
modules/fhir-path/src/blaze/fhir_path.clj 89.06% <100.00%> (ø)
...fhir-structure/src/blaze/fhir/spec/type/system.clj 92.99% <100.00%> (+1.32%) ⬆️

The equal search worked like approximately (ap) search. Now it tests for
fully contains instead of overlapping. The Prefixes sa (starts-after),
eb (ends-before) and ap (approximately) were also added.

Closes: #666
@alexanderkiel alexanderkiel merged commit 4e41969 into develop Apr 30, 2023
93 checks passed
@alexanderkiel alexanderkiel deleted the fix-date-search branch April 30, 2023 19:53
@alexanderkiel alexanderkiel added this to the v0.20.4 milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request module:db
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant