Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Date Search Performance #977

Merged
merged 1 commit into from
May 1, 2023

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented May 1, 2023

Used indexes for equal, less than and starts after. That operators all have a predicate on the lower bound of the resource value that comes first in the index. The other operators can't use the existing index, because they either look at the upper bound or on both bounds.

We have to add indexes in order to speed up the other operators. The issue is: #976.

Performance documentation can be found here.

@alexanderkiel alexanderkiel self-assigned this May 1, 2023
@alexanderkiel alexanderkiel added module:db performance Performance improvement labels May 1, 2023
@alexanderkiel alexanderkiel added this to the v0.20.4 milestone May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #977 (86e120b) into develop (e43d296) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #977   +/-   ##
========================================
  Coverage    94.12%   94.12%           
========================================
  Files          238      238           
  Lines        15233    15235    +2     
  Branches       380      380           
========================================
+ Hits         14338    14340    +2     
  Misses         515      515           
  Partials       380      380           
Impacted Files Coverage Δ
...laze/db/impl/index/search_param_value_resource.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/impl/search_param/date.clj 97.50% <100.00%> (-0.07%) ⬇️

@alexanderkiel alexanderkiel force-pushed the improve-date-search-performance branch 2 times, most recently from 2bd89f9 to 6b38a22 Compare May 1, 2023 18:11
Used indexes for equal, less than and starts after. That operators all
have a predicate on the lower bound of the resource value that comes
first in the index. The other operators can't use the existing index,
because they either look at the upper bound or on both bounds.

We have to add indexes in order to speed up the other operators. The
issue is: #976.
@alexanderkiel alexanderkiel force-pushed the improve-date-search-performance branch from 6b38a22 to 86e120b Compare May 1, 2023 18:12
@alexanderkiel alexanderkiel merged commit 2e3e4f0 into develop May 1, 2023
127 checks passed
@alexanderkiel alexanderkiel deleted the improve-date-search-performance branch May 1, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:db performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant