Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Extended Birth Date in CQL #985

Merged
merged 1 commit into from
May 7, 2023
Merged

Fix Extended Birth Date in CQL #985

merged 1 commit into from
May 7, 2023

Conversation

alexanderkiel
Copy link
Member

For age calculation in CQL, the property birthDate.value is used. That .value part means that we have to get the value of the FHIR date type. We never did this and so got ExtendedDate into the CQL evaluation which doesn't work.

Also overhauled the System.Date and System.DateTime types. Decided to implement them in Java. Improved the parsing performance by about 4 times. For Date/DateTime up to Date precision.

Closes: #973

@alexanderkiel alexanderkiel self-assigned this May 7, 2023
@alexanderkiel alexanderkiel added bug Something isn't working performance Performance improvement labels May 7, 2023
@alexanderkiel alexanderkiel added this to the v0.20.5 milestone May 7, 2023
For age calculation in CQL, the property birthDate.value is used. That
.value part means that we have to get the value of the FHIR date type.
We never did this and so got ExtendedDate into the CQL evaluation which
doesn't work.

Also overhauled the System.Date and System.DateTime types. Decided to
implement them in Java. Improved the parsing performance by about 4
times. For Date/DateTime up to Date precision.

Closes: #973
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #985 (3ece5a7) into develop (2f82a0e) will increase coverage by 0.02%.
The diff coverage is 94.21%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #985      +/-   ##
===========================================
+ Coverage    94.13%   94.16%   +0.02%     
===========================================
  Files          238      238              
  Lines        15237    15107     -130     
  Branches       379      374       -5     
===========================================
- Hits         14343    14225     -118     
+ Misses         515      508       -7     
+ Partials       379      374       -5     
Impacted Files Coverage Δ
modules/cql/src/blaze/elm/protocols.clj 100.00% <ø> (ø)
...s/cql/src/blaze/elm/compiler/structured_values.clj 77.10% <76.19%> (+0.29%) ⬆️
modules/cql/src/blaze/elm/date_time.clj 93.23% <91.48%> (-0.53%) ⬇️
...fhir-structure/src/blaze/fhir/spec/type/system.clj 96.76% <95.61%> (+3.76%) ⬆️
modules/anomaly/src/blaze/anomaly.clj 100.00% <100.00%> (ø)
modules/anomaly/src/blaze/anomaly_spec.clj 100.00% <100.00%> (ø)
.../cql/src/blaze/elm/compiler/clinical_operators.clj 100.00% <100.00%> (ø)
...cql/src/blaze/elm/compiler/date_time_operators.clj 75.40% <100.00%> (-2.49%) ⬇️
...dules/cql/src/blaze/elm/compiler/reusing_logic.clj 85.26% <100.00%> (+2.46%) ⬆️
modules/cql/src/blaze/elm/decimal.clj 99.09% <100.00%> (-0.06%) ⬇️
... and 4 more

@alexanderkiel alexanderkiel merged commit 5c7865d into develop May 7, 2023
127 checks passed
@alexanderkiel alexanderkiel deleted the 973-cql-extended branch May 7, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:cql module:fhir-structure performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant