Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove images #1

Closed
samporapeli opened this issue Jul 14, 2021 · 1 comment · Fixed by #21
Closed

Remove images #1

samporapeli opened this issue Jul 14, 2021 · 1 comment · Fixed by #21
Labels
enhancement New feature or request

Comments

@samporapeli
Copy link
Owner

Add possibility to remove an image. Only the uploader of the image should be able to remove that image.
@felixbade
Copy link
Collaborator

There should be some kind of safety mechanism to preventing accidental deletes. JS prompt() could be good.

@felixbade felixbade added the enhancement New feature or request label Jul 24, 2021
felixbade added a commit that referenced this issue Aug 1, 2021
@felixbade
Add functional image deletion route (fix #1)
1007a7c
@felixbade felixbade mentioned this issue Aug 1, 2021
Merged
samporapeli pushed a commit that referenced this issue Aug 2, 2021
@felixbade
Add feature: remove images (#21)
04ea07a 
* Save PNGs as JPEGs so they don’t break

* Convert RGBA images to RGB with white background (fix #15)

* Add dummy image deletion button if current user uploaded the image

* Add image deletion JS prompt

* Implement image deletion prompt with form validation

* Add functional image deletion route (fix #1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/remove images samporapeli/ruoka
2 participants
@felixbade @samporapeli