Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vimeo player mute button doesn't work on mobile phones any more #2624

Open
dowixxx opened this issue Feb 20, 2023 · 1 comment
Open

Vimeo player mute button doesn't work on mobile phones any more #2624

dowixxx opened this issue Feb 20, 2023 · 1 comment

Comments

@dowixxx
Copy link

dowixxx commented Feb 20, 2023

I can see the same behaviour on https://plyr.io/#vimeo. On desktop everything works fine, but when i checked on a few different phones "mute" button doesn't work any more (it does not mute the video), even at plyr.io homepage.

Please fix this!
@HandreMelo
Copy link
Contributor

HandreMelo commented Feb 20, 2023 •
edited

I had the same issue here, but only on IOS.
I found a solution for that, but i don't know how to apply now to the project.
In the file Vimeo.js, at line 268 the player.embed.setVolume has to be changed to setMuted. For some reason, ios doesn't accept this api volume changes .

HandreMelo pushed a commit to HandreMelo/plyr that referenced this issue Feb 24, 2023
@andremelo-dot
fix(issue sampotts#2624): Changing player.embed function call from se…
891368a 
…tVolume to setMuted in src/plugins/Vimeo.js.

setVolume(0) used before by muted button, didn't work on IOS
@HandreMelo HandreMelo mentioned this issue Feb 24, 2023
Merged
sampotts pushed a commit that referenced this issue Feb 25, 2023
@HandreMelo @andremelo-dot
fix(issue #2624): Changing player.embed function call from setVolume …
fa634a1 
…to setMuted in src/plugins/Vimeo.js. (#2628)

setVolume(0) used before by muted button, didn't work on IOS

Co-authored-by: Andre Fernandes Cristofolini Melo <andre.melo@dotgroup.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HandreMelo @dowixxx