Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save captions state #311

Closed
alethea opened this issue Jul 12, 2016 · 3 comments
Closed

Save captions state #311

alethea opened this issue Jul 12, 2016 · 3 comments
Labels
Feature

Comments

@alethea
Copy link

alethea commented Jul 12, 2016 •
edited

I noticed plyr stores the video volume in local storage to stay consistent between videos/plays of videos. I think the captions on/off state could also benefit from being preserved at the user's preference. I'm happy to make a PR if you think this is worthwhile.
@sampotts
Copy link
Owner

Yeah that would be a good idea! 👍

alethea added a commit to alethea/plyr that referenced this issue Jul 16, 2016
@alethea
Save caption state in localStorage (resolves sampotts#311)
cd88b5e
@alethea alethea mentioned this issue Jul 16, 2016
Closed
alethea added a commit to alethea/plyr that referenced this issue Jul 22, 2016
@alethea
Save captions state to localStorage (resolves sampotts#311)
095ad7b 
Also update localStorage to use a JSON object store for future
extensibility.
alethea added a commit to alethea/plyr that referenced this issue Jul 22, 2016
@alethea
Save captions state to localStorage (resolves sampotts#311)
ac425cb 
Also update localStorage to use a JSON object store for future
extensibility.
@sampotts
Copy link
Owner

sampotts commented Aug 21, 2016 •
edited

Merged in v2.0.0 - thanks again for this 👍

@alethea
Copy link
Author

alethea commented Aug 21, 2016

No problem! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sampotts @alethea