-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Array as selector in .setup() #319
Comments
Just added this - could you give it a test? 👍 |
Thanks a lot for the implementation! Made a small documentation for it and will try it next week. |
Tested. Works perfectly! |
Awesome 👍 Cheers for the docs update too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
plyr.setup()
currently supports NodeList, HTMLElement and a string selector, but sometimes it's easier to work with Arrays instead of NodeLists. Especially when performing a lot of filtering using.map
,.filter
, ….Passing an array to
plyr.setup()
doesn't throw an error and simply uses the default values:<video>
,<audio>
and[data-type]
.Supporting Arrays like
[HTMLElement, HTMLElement]
would be a nice addition.The text was updated successfully, but these errors were encountered: