You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closed captions show on the video if a track element with a valid source is present.
Actual behaviour
No captions show unless a srclang attribute is set on the track element(s).
Environment
Browser: Google Chrome
Version: 65.0.3325.181
Operating System: macOS
Version: 10.12.6
Steps to reproduce
Setup a Plyr instance with a <track>. Don't set the srclang attribute on the track element(s).
This is browser independent. The Plyr instance tries to get the current track via language matching on the tracks in the media object, so if you have one or more tracks and none of them have a srclang attribute, no captions will show. Relevant Code
I'm not sure that this is a bug, but the behavior changed between v2.0.18 and v3 and wasn't mentioned as a breaking change in the release notes. Just thought I'd file an issue since I worked at this for a while when upgrading.
The text was updated successfully, but these errors were encountered:
Expected behaviour
Closed captions show on the video if a track element with a valid source is present.
Actual behaviour
No captions show unless a
srclang
attribute is set on the track element(s).Environment
Steps to reproduce
<track>
. Don't set thesrclang
attribute on the track element(s).This is browser independent. The Plyr instance tries to get the current track via language matching on the tracks in the media object, so if you have one or more tracks and none of them have a srclang attribute, no captions will show. Relevant Code
I'm not sure that this is a bug, but the behavior changed between v2.0.18 and v3 and wasn't mentioned as a breaking change in the release notes. Just thought I'd file an issue since I worked at this for a while when upgrading.
The text was updated successfully, but these errors were encountered: