Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions won't show unless the track(s) have a srclang attribute #875

Closed
FlipgridMartin opened this issue Apr 5, 2018 · 1 comment
Closed
Assignees
Labels

Comments

@FlipgridMartin
Copy link

Expected behaviour

Closed captions show on the video if a track element with a valid source is present.

Actual behaviour

No captions show unless a srclang attribute is set on the track element(s).

Environment

  • Browser: Google Chrome
  • Version: 65.0.3325.181
  • Operating System: macOS
  • Version: 10.12.6

Steps to reproduce

  • Setup a Plyr instance with a <track>. Don't set the srclang attribute on the track element(s).

This is browser independent. The Plyr instance tries to get the current track via language matching on the tracks in the media object, so if you have one or more tracks and none of them have a srclang attribute, no captions will show. Relevant Code

I'm not sure that this is a bug, but the behavior changed between v2.0.18 and v3 and wasn't mentioned as a breaking change in the release notes. Just thought I'd file an issue since I worked at this for a while when upgrading.

@sampotts
Copy link
Owner

This should be resolved in v3.2.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants