Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video trimming UI plugin #1798

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Commits on Apr 2, 2020

  1. Configuration menu
    Copy the full SHA
    ba312b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72f1568 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Configuration menu
    Copy the full SHA
    4c75bcc View commit details
    Browse the repository at this point in the history
  2. If the user is using the trimming tool, check if the seek position is…

    … outside of the trimming region and set to the start of the trimming region
    DanielHuntleySBG committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    c82fa73 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2020

  1. Configuration menu
    Copy the full SHA
    f5bc729 View commit details
    Browse the repository at this point in the history
  2. Fix to only update the current time when the user has finished settin…

    …g the trimming length (let go of trimming handle)
    DanielHuntleySBG committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    13d15b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2020

  1. Trimming tool: Implementation of timestamp above each thumb to displa…

    …y the seek position in the video | Trim plugin is also brought to be more inline with the existing code base (sass structure and change of this.tool to be this.elements)
    DanielHuntleySBG committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    ef5bccf View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Configuration menu
    Copy the full SHA
    d8ae6e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c9f8329 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5780e0d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e13be14 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5bb96f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Video trimming bug fix: When switching sources a new trimming object …

    …was not created | We should only display the trim thumb time tooltip when displaying preview thumbnails as a seek tooltip is displayed
    DanielHuntleySBG committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    2ab8a88 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Trimming: Change structure of triggerevent messages so that they are …

    …in the correct format and pass a valid element
    DanielHuntleySBG committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    c0fa6d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Configuration menu
    Copy the full SHA
    81d77eb View commit details
    Browse the repository at this point in the history
  2. Convert the default trim length to percent as for longer videos it wa…

    …s showing only a very small region
    DanielHuntleySBG committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ee73dc4 View commit details
    Browse the repository at this point in the history
  3. Addition of a couple additional api endpoints to get and set the star…

    …t and end points of the trimming range
    DanielHuntleySBG committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5e53137 View commit details
    Browse the repository at this point in the history
  4. Update to use the existing clamp function | Improve commenting for se…

    …tting the trim length | Prevent the end value of the trimming region from being before the start
    DanielHuntleySBG committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    83ab236 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Remove getter and setter for trimming from plyr.js as it can be acces…

    …sed via the trimming object and update documentation
    DanielHuntleySBG committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    bc2fbc4 View commit details
    Browse the repository at this point in the history
  2. Remove settrimstart and settrimend from plyr.js as they can be set fr…

    …om the trim class: unsure whether a setter should exist for both of these and what its naming convention would be, so have kept it set via the variables directly
    DanielHuntleySBG committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    bdf4718 View commit details
    Browse the repository at this point in the history
  3. Calling trim.enter or trim.exit did not update the video trim control…

    … so have moved the logic to inside the enter and exit function | Additionally removed toggling trimming from plyr.js as it can all be set via trim.xxx
    DanielHuntleySBG committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    04941a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Configuration menu
    Copy the full SHA
    64dc1fd View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Configuration menu
    Copy the full SHA
    6f06907 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Configuration menu
    Copy the full SHA
    3aed88e View commit details
    Browse the repository at this point in the history