Google Cast #412
Closed
Google Cast #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working on stuff
Plyr cast button now responds properly to current session state.
The button now represents whether the parent plyr is the one
that is currently assigned to ongoing cast session.
On page load, if there is no cast session, clicking the button
does two things:
- Show cast drop down
- Bind current plyr instance on successful session negotiation
However, on page load, if there already exists a cast session, the
button is still greyed out to signal that the plyr is not attached.
Upon click, the plyr is bound to the cast session and only the
icon is updated without going through cast connection.
The demo/cast-server.js requires 3 additional npm packages that have not been added to package.json: express, morgan, compression
|
Let me know if you want me to squash these commits. There is at least one unused file that made it into git history. |
|
any update on this ? |
|
There's supposedly a big update in the works. I could make progress on this, but it would just mean massive merge conflicts once that update hits. Hence, I've sort of paused work on this till the big update is up. As it is, this PR changes a lot of code since it tries to re-use a lot of the helper functions that Plyr uses. |
|
👍 |
|
As @gurupras pointed out - I'm in the middle of a large update and want to get that out ideally before any more major work is done |
|
Closing this and opening a new PR #706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds google cast capabilities to plyr.
Link to related issue (if applicable)
#112
Sumary of proposed changes
PlyrUtils,PlyrCast_injectScript,_on, etc) toPlyrUtils(these are used inPlyrCast)Task list
plyr.lesschanges make sensescsssources