Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Code with JS Doc #6

Open
danpastori opened this issue Oct 1, 2018 · 1 comment
Open

Comment Code with JS Doc #6

danpastori opened this issue Oct 1, 2018 · 1 comment

Comments

@danpastori
Copy link
Contributor

danpastori commented Oct 1, 2018

Problem

Code needs JSDoc comments for easy reading and documentation

Rationale

Utilizing JSDoc makes it easier to bring other developers on board and keeps
a standard for documenting code. This will help other contributors pick up the code and dive
right in. It also provides a baseline for how other contributors comment their features. The
standard is here: http://usejsdoc.org/

Solution

I will go through the existing Shr code, and comment all of the features and methods
using JSDoc.

Pros of Solution:

  • Code gets commented and easy for contributors to pick up.

Cons of Solution

  • Can take a little time to get used to the standards

Let me know if JSDoc is something you are interested in and I'll get it added and submit a PR

@sampotts
Copy link
Owner

sampotts commented Oct 2, 2018

Sounds great to me! I've started using it some other JavaScript libs and it makes total sense. 👍

sampotts added a commit that referenced this issue Nov 13, 2018
Added jsdoc to all of the methods and config for Shr. Fixes issue #6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants