New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not consider [silence] as "missing tracks" #1089
Comments
Sounds like a reasonable extension. Do you know if there's a way to unambiguously identify this kind of track with MusicBrainz metadata, or should we just look for the string "[silence]"? |
Just look for the string - it'll be the track title. The musicbrainz spec is here: https://beta.musicbrainz.org/doc/Style/Unknown_and_untitled/Special_purpose_track_title |
Cool. I'm not 100% sure how we should implement this—maybe we need an "inessential" flag on |
Ha I'm not sure either. I wish it could be as simple as |
Happens to the best of us. 😃 Check back in if you get a moment to hack. |
For This should be fixed in a few different steps.
We can get into more detail on the specific steps when we come to them, but that's the high-level outline. |
As I wrote on IRC:
I'm not saying it's a bad idea to filter on "[silence]" though, as that seems to be the most reliable thing to do detect silent tracks on MB regardless of reservations above - just as long as those reservations are kept in mind. |
@sampsyo I agree with most of what you said, however the original intent of my bug was not to detect silence tracks - I think they are already labeled as such in Musicbrainz. To clarify, occasionally there is an album with CD tracks that are silent and unnamed (don't appear on the album art, but exist as tracks when played on a CD player). The Musicbrainz spec is to give these a title of The issue arises when you rip the CD and delete these silent tracks. Currently beets will say "missing tracks", but some may argue that there's no harm in these being missing - and will not want to "punish" or risk mis-tagging due to their absence. Sorry if this was clear to everyone and I am beating a horse - just wanted to be on the same page. Merry Christmas or Festivus or whatever everyone :-) |
Yep, that's the goal. The first step is detecting the silence; then we can ignore those tracks. Thanks for checking back in! |
So, the point is to detect |
Yep, that's basically the idea—but we don't currently have an "ignorable" flag, so you'd need to implement that too. |
What is the |
A Does that help? |
@sampsyo do you have any [silence] examples? |
Here's one linked from that MusicBrainz wikipedia page: https://musicbrainz.org/release/9c0b5a23-ca6e-4b4e-be2f-98280cf56c88 |
What exactly should I look for in |
Exactly the point you pointed toward in this comment: #2315 (comment) That is, where we apply the penalty for missing tracks. |
Many albums have silent tracks, labelled as "[silence]" in musicbrainz. If these tracks are missing, it should be ignored.
The text was updated successfully, but these errors were encountered: