Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop option to FtInTitlePlugin #692

Merged
merged 4 commits into from Apr 22, 2014
Merged

Conversation

SUTJael
Copy link
Contributor

@SUTJael SUTJael commented Apr 15, 2014

No description provided.

@sampsyo
Copy link
Member

sampsyo commented Apr 15, 2014

Awesome! Thanks for the quick fix!

It looks like Travis is complaining of a couple of small formatting issues:
https://travis-ci.org/sampsyo/beets/jobs/23072112#L317

It would also be nice to have a configuration option too to make the flag sticky, right? Fortunately, Confit should make that really easy.

@SUTJael
Copy link
Contributor Author

SUTJael commented Apr 16, 2014

Ok will check that tonight ;)

Drop parameter sticky
@SUTJael
Copy link
Contributor Author

SUTJael commented Apr 21, 2014

@sampsyo, just updated the pull request, could you check if it's good for you? (It's my first python script so I based my changes regarding other plugins). I'm not sure about the sticky part but for what I can understand of the syntax, it seems good.

@sampsyo sampsyo merged commit 4d616ce into beetbox:master Apr 22, 2014
sampsyo added a commit that referenced this pull request Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants