Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added <a> tag to redirect singup/login pages and updated css #45

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

seog-jun
Copy link
Contributor

@seog-jun seog-jun commented Oct 7, 2023

Fixes #43
Hi,

I added tag to redirect sign up and login pages and assumed the first icon is signup, the second one is login. Also, I applied nav-links css class which is more clear vs user css class.

Let me know if there's something that needs to be changed. Thanks!

p.s Prettier is automatically applied to the index.html file

@seog-jun
Copy link
Contributor Author

seog-jun commented Oct 7, 2023

Can you please review the PR? Thanks, and let me know if there's something to be fixed.

@samratghosh291
Copy link
Owner

@seog-jun still it has some conflict. Please look into it.

@seog-jun
Copy link
Contributor Author

seog-jun commented Oct 8, 2023

@samratghosh291 Fixed, could you please look into this PR first?

@samratghosh291 samratghosh291 merged commit f553f3b into samratghosh291:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signin-login page is not working
2 participants