Skip to content
This repository has been archived by the owner on Nov 8, 2020. It is now read-only.

Fix: Column Switcher Key #11

Merged
merged 3 commits into from
Aug 22, 2018
Merged

Fix: Column Switcher Key #11

merged 3 commits into from
Aug 22, 2018

Conversation

dmitriy-kudelko
Copy link
Collaborator

@dmitriy-kudelko dmitriy-kudelko commented Aug 22, 2018

title isn't a required prop and might not be set for certain columns, so it's required to use some other prop as a key. Otherwise it throws an error.

Copy link
Owner

@samrith-s samrith-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@samrith-s
Copy link
Owner

@dmitriy-kudelko Can you probably resolve conflicts and do a push?

# Conflicts:
#	src/components/ColumnSwitcher/index.js
@dmitriy-kudelko
Copy link
Collaborator Author

@samrith-s , done.

@samrith-s samrith-s merged commit cb5ff6c into master Aug 22, 2018
@samrith-s samrith-s deleted the fix/column-switcher-key branch August 22, 2018 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants