This repository has been archived by the owner on Nov 8, 2020. It is now read-only.
Column Switcher: Improvements #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrith-s
approved these changes
Aug 23, 2018
| {columns.map(({ title, dataKey, visible: isChecked }) => ( | ||
| <ColumnSwitcherItem | ||
| key={dataKey} | ||
| {...{ |
There was a problem hiding this comment.
Maybe we should create a variable and spread that here, because I feel this is a bit difficult to read, but we could always do this later.
| } | ||
| }; | ||
|
|
||
| Column.propTypes = { |
There was a problem hiding this comment.
We could also add propTypes and defaultProps for other props passed to column component as well to make it easier to read and understand. I'll pick this one up if you are focusing on other features.
There was a problem hiding this comment.
Yes, I think this is a good idea 'cause currently you can't rely on IDE's suggestions to insert a prop since they aren't listed in prop types.
There was a problem hiding this comment.
Yep, I will pick this up in a new PR later today.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: