Skip to content
This repository has been archived by the owner on Nov 8, 2020. It is now read-only.

Basic filter with column values #8

Closed
wants to merge 7 commits into from

Conversation

kumarankit1234
Copy link
Collaborator

This PR adds
i. Column filter to each columns

@samrith-s
Copy link
Owner

samrith-s commented Aug 27, 2018

@kumarankit1234 @dmitriy-kudelko Is this PR still valid? Will close it otherwise. If yes, do fix conflicts and update WIP.

@kumarankit1234 kumarankit1234 changed the title [WIP]Basic filter with column values Basic filter with column values Aug 28, 2018
@samrith-s
Copy link
Owner

@kumarankit1234 The bug #18 has come to notice because of this implementation. We need to resolve that before this is merged. Will review it in the meanwhile.

@samrith-s
Copy link
Owner

As discussed, let's completely mitigate the complexities arising due to us filtering data. Let's in-fact give the user the ability to render custom column filters if need by, on a per-column basis.

We could go with something like:

<Column filterRenderer={CustomFilterRenderer} />

What props do you think should we pass to the renderer? Let's keep it at a bare minimum, but just enough to help the user filter data.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants