Log errors received during setClimateOn (#13)

* Log errors received during setClimateOn * Make error test not dependent on format of error messaging * Bump version number
samrum · Sep 19, 2019 · 0014e68 · 0014e68
1 parent 4664680
commit 0014e68
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "homebridge-onstar",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "Unofficial OnStar plugin for Homebridge",
   "main": "dist/index.js",
   "types": "dist/src/index.d.ts",

diff --git a/src/CommandDelegator.ts b/src/CommandDelegator.ts
@@ -26,7 +26,10 @@ class CommandDelegator {
 
       reply(null);
     } catch (e) {
-      reply(`Error: ${e.message}`);
+      const errorMessage = `setClimateOn: Error: ${e.message}`;
+
+      this.log(errorMessage);
+      reply(errorMessage);
     }
   }
 }

diff --git a/test/CommandDelegator.test.ts b/test/CommandDelegator.test.ts
@@ -46,7 +46,8 @@ describe("OnStarAccessory", () => {
     when(onStarMock.start()).thenThrow(new Error(errorMessage));
 
     commandDelegator.setClimateOn(true, (error: string) => {
-      expect(error).toEqual(`Error: ${errorMessage}`);
+      expect(error).toBeDefined;
+      expect(error).not.toBeNull;
       done();
     });
   });