Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

revert sqlgen changes #167

Merged
merged 21 commits into from
Sep 12, 2018
Merged

revert sqlgen changes #167

merged 21 commits into from
Sep 12, 2018

Conversation

changpingc
Copy link
Contributor

@changpingc changpingc commented Sep 12, 2018 •
edited
Loading

We ran into performance issues related to the sqlgen changes from #142, #151, #154, #155 and #156, skipping over #153. This PR reverts them with

git revert 1d4b04da9bcfd74a70fa6160e16440e8cd6f4ae3^..73fa22fc978c7b42c96fe6ce92888de517ad0da4
git revert 221d1802a37b8ddbb69278b4937ffe695be2a6a3^..0fb3926c91670ad0cbe8f3b1a262eb47957cfe96

@changpingc
Revert "Add entry to changelog for last PR"
7f7c7b5 
This reverts commit 73fa22f.
@changpingc
Revert "go sqlgen: fix bug in initial tag release"
a9982f7 
This reverts commit 56df127.
@changpingc
Revert "go fields: handle time like we did before, with mysql.NullTime"
bc98a3a 
This reverts commit 1d4b04d.
@changpingc
Revert "changelog: Add 0.3.0 entry"
0f31253 
This reverts commit 0fb3926.
@changpingc
Revert "go sqlgen: remove Scanner.Interface()"
7d271df 
This reverts commit 1d2ccd4.
@changpingc
Revert "go sqlgen: support nullable (pointer) sql.Scanners"
719f9d6 
This reverts commit 39f0128.
@changpingc
Revert "Add Changelog entry for type changes"
1e53b51 
This reverts commit ac515ec.
@changpingc
Revert "go sqlgen: Use assert.Equal over pretty.Compare"
6e8ab60 
This reverts commit 4d17995.
@changpingc
Revert "go {livesql,sqlgen,example}: import mysql"
7d1c7ed 
This reverts commit adf5103.
@changpingc
Revert "go livesql: use new type system"
e5fad45 
This reverts commit 094fb4d.
@changpingc
Revert "sqlgen: add filter and write paths"
a55dc57 
This reverts commit f7b552d.
@changpingc
Revert "go sqlgen: implement read path"
b05c12b 
This reverts commit df7d436.
@changpingc
Revert "go testfixtures: add stringer to CustomType"
5eb671a 
This reverts commit 9fa76f3.
@changpingc
Revert "go fields: add test specifically for protobuf"
6cc910a 
This reverts commit e40fabc.
@changpingc
Revert "go internal: add proto example for testing"
78847c6 
This reverts commit 9a87d53.
@changpingc
Revert "go fields: Add validation of SQL types"
b2e27c0 
This reverts commit a2708f1.
@changpingc
Revert "go fields: Scanner satisfies sql.Scanner interface"
9dc36b4 
This reverts commit e5ba676.
@changpingc
Revert "go fields: Valuer satisfies sql/driver.Valuer interface"
e78ea9b 
This reverts commit 504c20d.
@changpingc
Revert "go fields: add Marshal interface"
3b8784f 
This reverts commit 35e2c19.
@changpingc
Revert "go fields: introduce fields as a concept"
cd86418 
This reverts commit f0deeb7.
@changpingc
Revert "go testfixtures: test non-native SQL type in sqlgen/livesql"
95e083a 
This reverts commit 221d180.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 986

  • 98 of 138 (71.01%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 63.751%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sqlgen/reflect.go 93 133 69.92%
Files with Coverage Reduction New Missed Lines %
livesql/binlog.go 1 66.67%
sqlgen/reflect.go 3 74.86%
graphql/schemabuilder/reflect.go 6 71.3%
Totals Coverage Status
Change from base Build 970: -0.8%
Covered Lines: 3127
Relevant Lines: 4905
💛 - Coveralls

berfarah
berfarah approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@berfarah berfarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Checked with git checkout changping/revert && git diff v0.1.0 - looks good

@changpingc changpingc merged commit 3341c4c into master Sep 12, 2018
@changpingc changpingc deleted the changping/revert branch September 12, 2018 22:19
@changpingc changpingc mentioned this pull request Sep 12, 2018
Merged
@berfarah
Copy link
Contributor

nvm, we have a fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@berfarah berfarah berfarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@changpingc @coveralls @berfarah