Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error leading to a pause (KeyError: 'error') #961

Closed
slifty opened this issue Aug 21, 2023 · 4 comments
Closed

Unexpected error leading to a pause (KeyError: 'error') #961

slifty opened this issue Aug 21, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@slifty
Copy link
Sponsor

slifty commented Aug 21, 2023

Describe the bug
I have an issue where maestral moves to a paused state unexpectedly. When viewing the logs I see:

2023-08-21 10:10:10 manager ERROR: Unexpected error
Traceback (most recent call last):
  File "Contents/Resources/app_packages/maestral/manager.py", line 841, in _handle_sync_thread_errors
  File "Contents/Resources/app_packages/maestral/manager.py", line 826, in startup_worker
  File "Contents/Resources/app_packages/maestral/sync.py", line 1597, in upload_local_changes_while_inactive
  File "Contents/Resources/app_packages/maestral/sync.py", line 1850, in apply_local_changes
  File "Contents/Resources/Support/Python/Resources/lib/python3.10/concurrent/futures/_base.py", line 608, in result_itera
tor
  File "Contents/Resources/Support/Python/Resources/lib/python3.10/concurrent/futures/_base.py", line 438, in result
  File "Contents/Resources/Support/Python/Resources/lib/python3.10/concurrent/futures/_base.py", line 390, in __get_result
  File "Contents/Resources/Support/Python/Resources/lib/python3.10/concurrent/futures/thread.py", line 52, in run
  File "Contents/Resources/app_packages/maestral/sync.py", line 2202, in _create_remote_entry
  File "Contents/Resources/app_packages/maestral/sync.py", line 2453, in _on_local_folder_created
  File "Contents/Resources/app_packages/maestral/errorhandling.py", line 849, in wrapper
  File "Contents/Resources/app_packages/maestral/client.py", line 1077, in make_dir
  File "Contents/Resources/app_packages/dropbox/base.py", line 1174, in files_create_folder_v2
  File "Contents/Resources/app_packages/dropbox/dropbox_client.py", line 323, in request
  File "Contents/Resources/app_packages/dropbox/dropbox_client.py", line 473, in request_json_string_with_retry
  File "Contents/Resources/app_packages/dropbox/dropbox_client.py", line 593, in request_json_string
  File "Contents/Resources/app_packages/dropbox/dropbox_client.py", line 645, in raise_dropbox_error_for_resp
KeyError: 'error'
2023-08-21 10:10:10 manager INFO: Shutting down threads...
2023-08-21 10:10:10 sync INFO: Sync aborted
2023-08-21 10:10:10 manager INFO: Paused

To Reproduce
Unclear how to reproduce yet, but I'll update if I can find a way.

Expected behaviour
Ideally this error would be handled and syncing would continue

System:

  • Maestral version: 1.8.0
  • Python version: 3.10.1
  • OS: MacOS 12.6
  • Desktop environment: MacOS
  • PyQt version (for Linux GUI): N/A

Additional context
Looking at #939 I'm not seeing error logs that look quite like this, so I wanted to open a more specific issue.

@slifty slifty added the bug Something isn't working label Aug 21, 2023
@slifty slifty changed the title Unexpected error leading to a paus (KeyError: 'error') Unexpected error leading to a pause (KeyError: 'error') Aug 21, 2023
@samschott
Copy link
Owner

Looks like this is an issue with rate limiting errors (code 429) that are returned by the Dropbox API having a different format than what is expected by the Dropbox Python SDK. I'll flag this with the Dropbox team.

@samschott
Copy link
Owner

I've flagged in this in the Dropbox forum at https://www.dropboxforum.com/t5/Discuss-Dropbox-Developer-API/429-rate-limit-errors-without-quot-error-quot-tag/m-p/709587#M3542.

@samschott
Copy link
Owner

Should be fixed now, the issue was indeed on the Dropbox side.

@slifty
Copy link
Sponsor Author

slifty commented Aug 31, 2023

Thank you so much for digging in and getting it fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants