Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No CHANGELOG #1442

Closed
scottkidder opened this issue Dec 4, 2018 · 14 comments
Closed

No CHANGELOG #1442

scottkidder opened this issue Dec 4, 2018 · 14 comments
Labels

Comments

@scottkidder
Copy link
Contributor

Hello,
Shouldn't there be somewhere to see a list of changes between releases? I understand this is supposed to be in GitHub releases, but there is nothing there for 0.4.10. The number of changes between 0.4.9 and 0.4.10 is significant and I immediately ran into issues with no where to look to see what may have caused them.

@samselikoff
Copy link
Collaborator

samselikoff commented Dec 5, 2018

Sorry about that Scott! I stopped keeping the changes in CHANGELOG because I didn't like creating new commits after a version was cut just to update the log.

My apologies for not putting any notes in the 4.10 release, but it should have just been bugfixes. I will start putting a link to the list of commits between releases in the release notes, so you can easily browse the commits.

As far as your bug(s), what are you running into?

@nathancharles
Copy link

nathancharles commented Dec 8, 2018

I am also seeing issues after upgrading from 0.4.9 to 0.4.10.

Mirage: You called server.createList('accountUsers') but no model or factory was found. Make sure you're using the singularized version of your model.

Where my model and factory are both named account-users.

It looks like pluralization of records changed when creating or referencing.
9b7c295

I agree a changelog would be great. Also, a minor version bump would be best since this is a significant and breaking change.
Migrating all references like this will definitely be non-trivial for my application.

@samselikoff
Copy link
Collaborator

@nathancharles thanks for the report. I will change this to a deprecation and release a 4.11

@makepanic
Copy link
Contributor

If you want to automate the CHANGELOG part, you could follow https://www.conventionalcommits.org/en/v1.0.0-beta.2/ as commit convention and use something like https://github.com/conventional-changelog/standard-version to bump npm version, tag version and generate updated CHANGELOG in one step.

It works pretty well for us in various projects.

@scottkidder
Copy link
Contributor Author

I've grown to love conventional commits as well, it seems to help out even on personal projects.

@kratiahuja
Copy link

@samselikoff do you need help with changing the error to deprecation? I can pick this up as this keeps breaking for us and we have to remember to pin it to 0.4.9.

@samselikoff
Copy link
Collaborator

@kratiahuja Think I'll be able to get to it tonight

@samselikoff
Copy link
Collaborator

Just opened PR #1452

@kratiahuja
Copy link

Thanks @samselikoff

@samselikoff
Copy link
Collaborator

@kratiahuja @nathancharles I've just released 0.4.11, could you give it a shot and let me know if it fixes it?

@samselikoff
Copy link
Collaborator

Make that 0.4.12 :)

@kratiahuja
Copy link

Thanks a lot @samselikoff

@scottkidder
Copy link
Contributor Author

The details on the latest releases look great! Thanks for being responsive on this @samselikoff

@nathancharles
Copy link

Thanks @samselikoff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants