Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastBoot 1.0 #1098

Merged
merged 2 commits into from
Jun 4, 2017
Merged

Fix FastBoot 1.0 #1098

merged 2 commits into from
Jun 4, 2017

Conversation

simonihmig
Copy link
Contributor

The upcoming FastBoot 1.0 (incl. latest RC versions) include breaking changes, that don't work anymore with ember-cli-mirage. See ember-fastboot/ember-cli-fastboot#387

This adds FastBoot tests (just testing that it does not break FastBoot rendering. They were failing at first with the latest FastBoot releases), and the required changes.

Note: I set engine to >= 4 to be able to use some ES6 in node. Hope that is ok!

@simonihmig
Copy link
Contributor Author

The failing scenario in Travis seems to be not related, a rerun should hopefully fix this! Will have to look at the codeclimate complains though...

@stefanpenner
Copy link
Collaborator

@simonihmig rerunning that one failed scenario.

@stefanpenner
Copy link
Collaborator

@simonihmig looks like the CI gods have accepted our offering.

You may want to look into the codeclimate stuff though.

@samselikoff
Copy link
Collaborator

Awesome -- thank you very much! (This would have taken me ages..)

I got rid of codeclimate so no worries there (it was too noisy)

🙇

@samselikoff samselikoff merged commit 419faac into miragejs:master Jun 4, 2017
@simonihmig
Copy link
Contributor Author

@samselikoff can we get a release with this? please 😛

@samselikoff
Copy link
Collaborator

@simonihmig
Copy link
Contributor Author

Awesome, thanks!

@billdami
Copy link

billdami commented Aug 29, 2017

@samselikoff @simonihmig Are there specific blockers/complications that require mirage to be disabled in fastboot? This seems to impede development quite a bit when running ember serve (which now runs fastboot), as livereloading while on a route that expects a mirage-backed model will 404 on the server-side, forcing you to either navigate back to that page once it renders on the client-side, or use ?fastboot=false to disable fastboot rendering altogether.

@simonihmig simonihmig deleted the fix-fastboot branch October 27, 2017 14:09
@simonihmig
Copy link
Contributor Author

@billdami sorry, missed your question. Basically, Mirage works be using pretender.js to intercept ajax requests and fake the response. In FastBoot however this does not work, as there is no Ajax in node.js, HTTP requests are made with node APIs. I am very much looking forward to a world where Mirage would work in FastBoot out of the box, as probably many others. But it's not there yet. And this is unrelated to this PR. I believe #1014 would solve that issue, but no idea how this is going forward...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants