Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-ons Prep for fastboot 1.0.0 #387

Closed
stefanpenner opened this issue May 17, 2017 · 18 comments
Closed

Add-ons Prep for fastboot 1.0.0 #387

stefanpenner opened this issue May 17, 2017 · 18 comments

Comments

@stefanpenner
Copy link
Contributor

stefanpenner commented May 17, 2017

Pre-req

  • release fastboot 1.0.0.rc1

What/Why?

The upcoming ember-cli-fastboot 1.0.0 release has some breaking changes, although we try hard to avoid any breaking changes these ones are hard to avoid (and we feel worth it) they:

  • dramatically improve build performance
  • unify ember fastboot --serve and ember s
  • put us on a path of success

How to upgrade:

@kratiahuja's upgrade guide: https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c

  • if you are upgrading or have submitting a pull request, please leave a comment in this issue and we will update the add-on list (and then remove your comment)

Addons

List of add-ons that match: https://emberobserver.com/code-search?codeQuery=process.env.EMBER_CLI_FASTBOOT

To check them off they should be either ready for 1.0.0, and add a link to any active PR that enables 1.0.0

*note: script for ^ https://gist.github.com/stefanpenner/ff5be0c7c2a3aabed49dd00fda8fd461 *

@stefanpenner stefanpenner changed the title create list of add-ons that need updating for 1.0.0 Add-ons Prep for fastboot 1.0.0 May 17, 2017
@simonihmig
Copy link
Contributor

@stefanpenner nice little script! 👌 I wonder if we could come up w/ something similar that takes this list and automatically creates an issue on each github repo? That way we could build awareness amongst the respective addon authors. Put links to @kratiahuja's guide and other helpful information into the template used to create the issue text...

I started some migrations by myself just to prepare addons that we use in our own app, but given the size of that list, and the fact that it actually grew quite a bit during the last weeks, I think we have to inform addon authors sooner than later, and rely on them making the necessary changes!

@stefanpenner
Copy link
Contributor Author

@stefanpenner nice little script! 👌 I wonder if we could come up w/ something similar that takes this list and automatically creates an issue on each github repo?

Totally, and this would in-general be a super useful tool. I unfortunately don't have the time, but would love it to exist (hint hint, if you have time).

@simonihmig
Copy link
Contributor

hint hint, if you have time

Hm, I can give it a try over the weekend I hope...

@simonihmig
Copy link
Contributor

@stefanpenner finally got this tool finished, did underestimate the effort a bit, but anyway here it is:
https://github.com/simonihmig/fastboot-migration-issue-creator

It uses the same logic as your shell script to fetch addons that need to be fixed, based on the emberobserver.com code search API, then checks if there is any existing open issue/PR containing "FastBoot 1.0" (skips those), and then creates an issue like this one: simonihmig/fastboot-migration-issue-creator-dummy-addon#6

If you see something that should be changed here, feel free to create an issue on its repo. Otherwise if that looks fine, I could run that script to create all those issues. If you prefer that to be done with some others github account, that would be ok for me as well...

cc @kratiahuja

@stefanpenner
Copy link
Contributor Author

@simonihmig very cool. I will try and give it a whirl this weekend!

@kratiahuja
Copy link
Contributor

@simonihmig super awesome! will give it a try!

@simonihmig
Copy link
Contributor

@kratiahuja @stefanpenner Sure, play with it. Just make sure to either use the -t or -d flag! ;) Just updated the Readme to make this more clear...

@leizhao4
Copy link

PR for ember-inputmask: adopted-ember-addons/ember-inputmask#39

I hope it's the correct way of fixing it because I'm not too familiar with FastBoot. If someone could help review the PR then it would be awesome.

Thanks for the great work!

@devotox
Copy link

devotox commented Jul 7, 2017

@kellyselden
Copy link
Member

v1.0.0 is live and we have a sufficient mass of updated addons that the rest can copy.

@Redsandro
Copy link

Can someone help me with this? In the examples, it seems awfully simple. But I seem err on every attempt.

gmurphey/ember-masonry-grid#58 (comment)

Disclaimer: I've never developed plugins for ember, just trying to get this to work so I can update my old fastboot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants