New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-ons Prep for fastboot 1.0.0 #387

Closed
stefanpenner opened this Issue May 17, 2017 · 18 comments

Comments

Projects
None yet
9 participants
@stefanpenner
Contributor

stefanpenner commented May 17, 2017

Pre-req

  • release fastboot 1.0.0.rc1

What/Why?

The upcoming ember-cli-fastboot 1.0.0 release has some breaking changes, although we try hard to avoid any breaking changes these ones are hard to avoid (and we feel worth it) they:

  • dramatically improve build performance
  • unify ember fastboot --serve and ember s
  • put us on a path of success

How to upgrade:

@kratiahuja's upgrade guide: https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c

  • if you are upgrading or have submitting a pull request, please leave a comment in this issue and we will update the add-on list (and then remove your comment)

Addons

List of add-ons that match: https://emberobserver.com/code-search?codeQuery=process.env.EMBER_CLI_FASTBOOT

To check them off they should be either ready for 1.0.0, and add a link to any active PR that enables 1.0.0

*note: script for ^ https://gist.github.com/stefanpenner/ff5be0c7c2a3aabed49dd00fda8fd461 *

@stefanpenner stefanpenner changed the title from create list of add-ons that need updating for 1.0.0 to Add-ons Prep for fastboot 1.0.0 May 17, 2017

@stefanpenner stefanpenner referenced this issue May 17, 2017

Merged

Refactor fastboot build to be more performant #369

28 of 34 tasks complete
@simonihmig

This comment has been minimized.

Show comment
Hide comment
@simonihmig

simonihmig May 17, 2017

Contributor

@stefanpenner nice little script! 👌 I wonder if we could come up w/ something similar that takes this list and automatically creates an issue on each github repo? That way we could build awareness amongst the respective addon authors. Put links to @kratiahuja's guide and other helpful information into the template used to create the issue text...

I started some migrations by myself just to prepare addons that we use in our own app, but given the size of that list, and the fact that it actually grew quite a bit during the last weeks, I think we have to inform addon authors sooner than later, and rely on them making the necessary changes!

Contributor

simonihmig commented May 17, 2017

@stefanpenner nice little script! 👌 I wonder if we could come up w/ something similar that takes this list and automatically creates an issue on each github repo? That way we could build awareness amongst the respective addon authors. Put links to @kratiahuja's guide and other helpful information into the template used to create the issue text...

I started some migrations by myself just to prepare addons that we use in our own app, but given the size of that list, and the fact that it actually grew quite a bit during the last weeks, I think we have to inform addon authors sooner than later, and rely on them making the necessary changes!

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner May 17, 2017

Contributor

@stefanpenner nice little script! 👌 I wonder if we could come up w/ something similar that takes this list and automatically creates an issue on each github repo?

Totally, and this would in-general be a super useful tool. I unfortunately don't have the time, but would love it to exist (hint hint, if you have time).

Contributor

stefanpenner commented May 17, 2017

@stefanpenner nice little script! 👌 I wonder if we could come up w/ something similar that takes this list and automatically creates an issue on each github repo?

Totally, and this would in-general be a super useful tool. I unfortunately don't have the time, but would love it to exist (hint hint, if you have time).

@simonihmig

This comment has been minimized.

Show comment
Hide comment
@simonihmig

simonihmig May 18, 2017

Contributor

hint hint, if you have time

Hm, I can give it a try over the weekend I hope...

Contributor

simonihmig commented May 18, 2017

hint hint, if you have time

Hm, I can give it a try over the weekend I hope...

@simonihmig

This comment has been minimized.

Show comment
Hide comment
@simonihmig

simonihmig May 26, 2017

Contributor

@stefanpenner finally got this tool finished, did underestimate the effort a bit, but anyway here it is:
https://github.com/simonihmig/fastboot-migration-issue-creator

It uses the same logic as your shell script to fetch addons that need to be fixed, based on the emberobserver.com code search API, then checks if there is any existing open issue/PR containing "FastBoot 1.0" (skips those), and then creates an issue like this one: simonihmig/fastboot-migration-issue-creator-dummy-addon#6

If you see something that should be changed here, feel free to create an issue on its repo. Otherwise if that looks fine, I could run that script to create all those issues. If you prefer that to be done with some others github account, that would be ok for me as well...

cc @kratiahuja

Contributor

simonihmig commented May 26, 2017

@stefanpenner finally got this tool finished, did underestimate the effort a bit, but anyway here it is:
https://github.com/simonihmig/fastboot-migration-issue-creator

It uses the same logic as your shell script to fetch addons that need to be fixed, based on the emberobserver.com code search API, then checks if there is any existing open issue/PR containing "FastBoot 1.0" (skips those), and then creates an issue like this one: simonihmig/fastboot-migration-issue-creator-dummy-addon#6

If you see something that should be changed here, feel free to create an issue on its repo. Otherwise if that looks fine, I could run that script to create all those issues. If you prefer that to be done with some others github account, that would be ok for me as well...

cc @kratiahuja

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner May 26, 2017

Contributor

@simonihmig very cool. I will try and give it a whirl this weekend!

Contributor

stefanpenner commented May 26, 2017

@simonihmig very cool. I will try and give it a whirl this weekend!

@kratiahuja

This comment has been minimized.

Show comment
Hide comment
@kratiahuja

kratiahuja May 27, 2017

Contributor

@simonihmig super awesome! will give it a try!

Contributor

kratiahuja commented May 27, 2017

@simonihmig super awesome! will give it a try!

@simonihmig

This comment has been minimized.

Show comment
Hide comment
@simonihmig

simonihmig May 27, 2017

Contributor

@kratiahuja @stefanpenner Sure, play with it. Just make sure to either use the -t or -d flag! ;) Just updated the Readme to make this more clear...

Contributor

simonihmig commented May 27, 2017

@kratiahuja @stefanpenner Sure, play with it. Just make sure to either use the -t or -d flag! ;) Just updated the Readme to make this more clear...

@kategengler

This comment has been minimized.

Show comment
Hide comment
@kategengler

kategengler Jun 10, 2017

Rerunning the above searches & limiting the results to addons that rank in the top 100, yields the following list (addon name, ranking, homepage):

Some other addons I'd suggest prioritizing that aren't in the top 100:
(addon name, score, last month's downloads, homepage) (oops, in reverse order of downloads)

kategengler commented Jun 10, 2017

Rerunning the above searches & limiting the results to addons that rank in the top 100, yields the following list (addon name, ranking, homepage):

Some other addons I'd suggest prioritizing that aren't in the top 100:
(addon name, score, last month's downloads, homepage) (oops, in reverse order of downloads)

@kratiahuja

This comment has been minimized.

Show comment
Hide comment
@kratiahuja

kratiahuja Jun 10, 2017

Contributor

@kategengler Awesome! thanks a bunch for this insightful info.

Contributor

kratiahuja commented Jun 10, 2017

@kategengler Awesome! thanks a bunch for this insightful info.

This was referenced Jun 25, 2017

@leizhao4

This comment has been minimized.

Show comment
Hide comment
@leizhao4

leizhao4 Jun 27, 2017

PR for ember-inputmask: brandynbennett/ember-inputmask#39

I hope it's the correct way of fixing it because I'm not too familiar with FastBoot. If someone could help review the PR then it would be awesome.

Thanks for the great work!

leizhao4 commented Jun 27, 2017

PR for ember-inputmask: brandynbennett/ember-inputmask#39

I hope it's the correct way of fixing it because I'm not too familiar with FastBoot. If someone could help review the PR then it would be awesome.

Thanks for the great work!

@devotox

This comment has been minimized.

Show comment
Hide comment

devotox commented Jul 7, 2017

@kellyselden

This comment has been minimized.

Show comment
Hide comment
@kellyselden

kellyselden Jul 20, 2017

Member

v1.0.0 is live and we have a sufficient mass of updated addons that the rest can copy.

Member

kellyselden commented Jul 20, 2017

v1.0.0 is live and we have a sufficient mass of updated addons that the rest can copy.

@Redsandro

This comment has been minimized.

Show comment
Hide comment
@Redsandro

Redsandro Mar 16, 2018

Can someone help me with this? In the examples, it seems awfully simple. But I seem err on every attempt.

gmurphey/ember-masonry-grid#58 (comment)

Disclaimer: I've never developed plugins for ember, just trying to get this to work so I can update my old fastboot.

Redsandro commented Mar 16, 2018

Can someone help me with this? In the examples, it seems awfully simple. But I seem err on every attempt.

gmurphey/ember-masonry-grid#58 (comment)

Disclaimer: I've never developed plugins for ember, just trying to get this to work so I can update my old fastboot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment