Merge pull request #210 from samsmithnz/ConvertedPercentsToWholeNumber

Converted percents to whole number
samsmithnz · Jan 5, 2023 · 3f3fd18 · 3f3fd18
2 parents 02ec1d3 + 9967384
commit 3f3fd18
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/RepoAutomation.Core/Helpers/RepoLanguageHelper.cs b/src/RepoAutomation.Core/Helpers/RepoLanguageHelper.cs
@@ -52,7 +52,7 @@ public static List<RepoLanguage> TransformRepoLanguages(Dictionary<string, int>
                 {
                     Name = item.Key,
                     Total = item.Value,
-                    Percent = Math.Round((decimal)item.Value / total, 3)
+                    Percent = Math.Round((decimal)item.Value / total * 100, 1)
                 });
                 if (repoLanguageDetails != null && repoLanguageDetails.ContainsKey(item.Key))
                 {

diff --git a/src/RepoAutomation.Core/Models/RepoLanguage.cs b/src/RepoAutomation.Core/Models/RepoLanguage.cs
@@ -4,6 +4,9 @@ public class RepoLanguage
     {
         public string? Name { get; set; }
         public int Total { get; set; }
+        /// <summary>
+        /// Note that percent is a number with one decimal place from 1.0-100.0, not 0.0 to 1.0.
+        /// </summary>
         public decimal Percent { get; set; }
         public string? Color { get; set; }
     }

diff --git a/src/RepoAutomation.Tests/RepoTests.cs b/src/RepoAutomation.Tests/RepoTests.cs
@@ -266,19 +266,19 @@ public async Task GetRepoLanguagesWithHelperTest()
         Assert.IsNotNull(repoLanguages);
         Assert.AreEqual(5, repoLanguages.Count);
         Assert.AreEqual("C#", repoLanguages[0].Name);
-        Assert.AreEqual(0.944M, repoLanguages[0].Percent);
+        Assert.AreEqual(94.4M, repoLanguages[0].Percent);
         Assert.AreEqual("#178600", repoLanguages[0].Color);
         Assert.AreEqual("HTML", repoLanguages[1].Name);
-        Assert.AreEqual(0.035M, repoLanguages[1].Percent);
+        Assert.AreEqual(3.5M, repoLanguages[1].Percent);
         Assert.AreEqual("#e34c26", repoLanguages[1].Color);
         Assert.AreEqual("CSS", repoLanguages[2].Name);
-        Assert.AreEqual(0.010M, repoLanguages[2].Percent);
+        Assert.AreEqual(1.0M, repoLanguages[2].Percent);
         Assert.AreEqual("#563d7c", repoLanguages[2].Color);
         Assert.AreEqual("Dockerfile", repoLanguages[3].Name);
-        Assert.AreEqual(0.009M, repoLanguages[3].Percent);
+        Assert.AreEqual(0.9M, repoLanguages[3].Percent);
         Assert.AreEqual("#384d54", repoLanguages[3].Color);
         Assert.AreEqual("JavaScript", repoLanguages[4].Name);
-        Assert.AreEqual(0.002M, repoLanguages[4].Percent);
+        Assert.AreEqual(0.2M, repoLanguages[4].Percent);
         Assert.AreEqual("#178600", repoLanguages[0].Color);
     }