Adjustment in calculation algorithm to use secret with furthest out e…

…xpiration date (#509)

* typo fix

* code gardening

* Fix to the calculation

* Bumping the minor version, as the Azure Service Principle watcher is basically done

GitVersion.yml

@@ -1 +1 @@
-next-version: 0.16.0
+next-version: 0.17.0

src/RepoGovernance.Core/Models/AzureAppRegistration.cs

@@ -30,15 +30,16 @@ public string ExpirationDateString
         {
             get
             {
-                DateTimeOffset? minDate = null;
+                DateTimeOffset? maxDate = null;
                 foreach (DateTimeOffset? item in ExpirationDates)
                 {
-                    if (item != null && (minDate == null || item < minDate))
+                    //Get the date furthest in the future
+                    if (item != null && (maxDate == null || item > maxDate))
                     {
-                        minDate = item;
+                        maxDate = item;
                     }
                 }
-                return minDate;
+                return maxDate;
             }
         }
 

src/RepoGovernance.Core/SummaryItemsDA.cs

@@ -89,6 +89,16 @@ public static List<UserOwnerRepo> GetRepos(string user)
             //Initialize the summary item
             SummaryItem? summaryItem = new(user, owner, repo);
 
+            if (azureDeployment == null && connectionString != null)
+            {
+                //check to make sure there isn't data in the table already for Azure deployments, and pull it out to save it
+                SummaryItem? existingItem = await GetSummaryItem(connectionString, owner, repo);
+                if (existingItem != null && existingItem.AzureDeployment != null)
+                {
+                    azureDeployment = existingItem.AzureDeployment;
+                }
+            }
+
             try
             {
                 //Get repo settings
@@ -329,37 +339,6 @@ public static List<UserOwnerRepo> GetRepos(string user)
                     }
                 }
 
-                //Get the Azure Deployment information
-                //AzureDeployment? azureDeployment = null;
-                //if (repo == "RepoGovernance")
-                //{
-                //    azureDeployment = new()
-                //    {
-                //        DeployedURL = "https://repogovernance-prod-eu-web.azurewebsites.net/",
-                //        AppRegistrations = new()
-                //        {
-                //            new AzureAppRegistration() { Name = "RepoGovernancePrincipal2023" },
-                //           new AzureAppRegistration() { Name = "RepoGovernanceGraphAPIAccess" }
-                //        }
-                //    };
-                //}
-                //else if (repo == "DevOpsMetrics")
-                //{
-                //    azureDeployment = new()
-                //    {
-                //        DeployedURL = "https://devops-prod-eu-web.azurewebsites.net//",
-                //        AppRegistrations = new()
-                //        {
-                //            new AzureAppRegistration() { Name = "DeveloperMetricsOrgSP2023" },
-                //            new AzureAppRegistration() { Name = "DevOpsMetrics" },
-                //            new AzureAppRegistration() { Name = "DevOpsMetricsServicePrincipal2022" }
-                //        }
-                //    };
-                //    if (summaryItem != null && azureDeployment != null)
-                //    {
-                //        summaryItem.AzureDeployment = azureDeployment;
-                //    }
-                //}
                 //If there are azure deployment records, then process the summary item and save the detail
                 if (azureDeployment != null &&
                     azureTenantId != null &&